Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use admin token for semantic release, and use dryrun for testing #1236

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −3
Open

Use admin token for semantic release, and use dryrun for testing #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09d4aa4
ci(publishing): add github.sha for commit status action
chrispymm Mar 3, 2025
6b7e55f
ci(publish): use a PAT with admin permissions and switch to ci:dryrun…
chrispymm Mar 4, 2025
3f71861
ci: add this branhc name to semantic release config for testing
chrispymm Mar 4, 2025
c941eb0
ci(publish): remove dryrun and test branch in config ready for merge
chrispymm Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/publish-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
uses: myrotvorets/set-commit-status-action@master
with:
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ github.sha }}
status: pending
context: Tests

Expand Down Expand Up @@ -76,13 +77,13 @@ jobs:
uses: myrotvorets/set-commit-status-action@master
with:
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ github.sha }}
status: ${{ needs.test.result }}
context: Tests

publish:
runs-on: ubuntu-latest
needs: [result]
if: github.event_name == 'push'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this protected us from running on a detached head of the combined PR branch + target

The "push" was the merge commit to main being pushed


steps:
- uses: actions/checkout@v4
Expand All @@ -105,4 +106,4 @@ jobs:
run: npm run ci:release
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
GITHUB_TOKEN: ${{ secrets.ADMIN_TOKEN }}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"build:package": "gulp build:package --color",
"postbuild:package": "govuk-prototype-kit validate-plugin package",
"ci:release": "CI=true semantic-release --debug",
"ci:dryrun": "CI=true semantic-release --dry-run",
"ci:dryrun": "CI=true semantic-release --debug --dry-run",
"start": "concurrently npm:watch:* --prefix none",
"test": "concurrently npm:test:* --group --prefix none",
"test:js": "jest --color src/",
Expand Down