Use admin token for semantic release, and use dryrun for testing #1236
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrispymm
commented
Mar 4, 2025
chrispymm
commented
- add a sha reference for the commit status action
- use an admin token for semantic release
- switch to ci:dryrun for testing purposes
chrispymm
force-pushed
the
use-admin-token
branch
from
4190fe5 to
e206ed6
Compare
chrispymm
force-pushed
the
use-admin-token
branch
from
e206ed6 to
c941eb0
Compare
| status: ${{ needs.test.result }} | ||
| context: Tests | ||
|
|
||
| publish: | ||
| runs-on: ubuntu-latest | ||
| needs: [result] | ||
| if: github.event_name == 'push' |
There was a problem hiding this comment.
I think this protected us from running on a detached head of the combined PR branch + target
The "push" was the merge commit to main being pushed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.