Fix bed night skip race condition #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
force-pushed
the
fix-bed-spamskip
branch
from
2a788c3
to
fbd98b9
Compare
sfan5
reviewed
Sep 27, 2023
appgurueu
force-pushed
the
fix-bed-spamskip
branch
from
fbd98b9
to
be4148e
Compare
appgurueu
force-pushed
the
fix-bed-spamskip
branch
from
be4148e
to
5016519
Compare
MoNTE48
pushed a commit
to MoNTE48/minetest_game
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3066 (partially, the other issue is an engine issue). How to test:
printinbeds.skip_night. Otherwise, don't spam click too fast, or the daytime won't have changed when the next set time of day hits, so the days counter will only be incremented by one. You have a whole 2 seconds to make your clicks, make about 3-4 clicks in that time (definitely don't make clicks with a < 100 ms (serverstep) frequency).