Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam-tapping on beds and more... #3066

Closed
EGYT5453 opened this issue Sep 26, 2023 · 3 comments · Fixed by #3067
Closed

Spam-tapping on beds and more... #3066

EGYT5453 opened this issue Sep 26, 2023 · 3 comments · Fixed by #3067
Labels

Comments

@EGYT5453
Copy link
Contributor

I thought that the bug I encountered was related to the "beds" mod (maybe it still is.)

MTG_bugs_beds_1.mp4

Short description:
The current day was 92;
I spam-tapped on the bed to lie down and get up again and again;
After waking up and seeing "You can only sleep at night", the current day was 99.

==========

But then I remembered about a bug I found earlier.
I was spam-tapping under myself, swimming in lava. Somehow Sam has become invincible (although he can't interact with the world. (place blocks, execute commands etc.))

MTG_bugs_bones_1_lq.r.r.mp4
MTG_bugs_bones_2_lq.r.mp4

Sorry for the low quality, GitHub doesn't allow files larger than 10MB.
Also, I don't fully understand how to replicate it. Sometimes it does, sometimes it doesn't.

If it helps, I was playing build 5.7.0 from F-Droid.

@appgurueu appgurueu added the Bug label Sep 26, 2023
@appgurueu
Copy link
Contributor

appgurueu commented Sep 26, 2023

Your first report seems like a genuine bug: After the first skipped night, it should be day, so you shouldn't be able to sleep again. This looks like a race condition; I'll look into it.

Edit: The problem seems to be pretty simple. Beds schedules night skips using minetest.after, but allows you to schedule multiple skips within two seconds.

The second report is unfortunately an engine issue.

@EGYT5453
Copy link
Contributor Author

I noticed that if you wake up before the day starts, it will be night for a few seconds, and the morning will start exactly when it would have started if you hadn't woken up before it. Maybe this is why it's possible to spam-tap the bed and skip days - MTG will add +1 to the days counter, but after you get out of bed, not after the morning starts (this is just a theory, as the only thing I've seen from the MTG code is the translation files.)

MTG_bugs_beds_3.mp4

Oh, and sometimes Sam doesn't want to lie in bed and sit in the boat, but that's off topic and probably already reported...

@appgurueu
Copy link
Contributor

[bed night skip bug stuff]

I've already found the issue and submitted a PR to fix this, see #3067.

Oh, and sometimes Sam doesn't want to lie in bed and sit in the boat, but that's off topic and probably already reported...

Yeah, that's indeed a duplicate of #3043. This is an engine issue too and has already been fixed in 5.8-dev, which will hopefully be released soon (probably in about a month or two).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants