Stairs: Add helper function for textures

[tenplus1]

Use function to tidy stair textures

[tenplus1]

@sfan5 - Thanks, amended pull. Also, what do you think about stairs automatically using node sounds ?

[sfan5]

Also, what do you think about stairs automatically using node sounds ?

sounds useful

[appgurueu]

If I'm seeing this correctly, the only thing this function is ever used for is to "transplant" a few definition fields? Why not refactor it to be a local function transplant_def_fields(nodename, to_def)?

The code would then become something like

local def = minetest.registered_nodes[nodename]
if not def then return end
for _, field in ipairs({"light_source", "use_texture_alpha", "sunlight_propagates", "sounds"}) do
    if to_def[field] == nil then
        to_def[field] = def[field]
    end
end

Or alternatively, something like register_node_based_on(nodename, base_nodename, def)?

Another alternative to get rid of get_node_vars: Replace its usage with local def = minetest.registered_nodes[nodename] or {}, then you can directly access def fields as def.light_source etc.

[appgurueu]

Looks fine as the "minimal change" for the sounds, but ideally get_node_vars with its 4 return values - which fulfill pretty much just the purpose of implementing JS's ?. - is a pretty dirty function.

[tenplus1]

Looks fine as the "minimal change" for the sounds, but ideally get_node_vars with its 4 return values - which fulfill pretty much just the purpose of implementing JS's ?. - is a pretty dirty function.

This is how I handle it in Stairs Redo, seems a lot tidier too :)