Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MT5 builtin’s translation system on all the modpack #529

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Use MT5 builtin’s translation system on all the modpack #529

wants to merge 18 commits into from

Conversation

louisroyer
Copy link
Contributor

If you are using an already created map to test this PR, you may need to break and replace some nodes (like chests) to see effects.

@louisroyer louisroyer force-pushed the locale-mt5 branch 3 times, most recently from c1d77c2 to f484b21 Compare February 18, 2020 12:14
@louisroyer louisroyer mentioned this pull request Feb 18, 2020
Closed
@louisroyer louisroyer mentioned this pull request Mar 13, 2020
Closed
louisroyer
louisroyer commented Mar 13, 2020
View reviewed changes
Copy link
Contributor Author

@louisroyer louisroyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to rework on some points

@SmallJoker SmallJoker mentioned this pull request Mar 19, 2020
Closed
@louisroyer
Copy link
Contributor Author

louisroyer commented Aug 12, 2020 •
edited
Loading

@louisroyer TODO:

  • rebase
  • re-test

@louisroyer
Copy link
Contributor Author

Note: some strings on battery box nodes overflow the formspec (but it is not a regression since this also occurs on master). Must I fix the size of the formspec in this PR (by extending on the right) or do it in another one?
example:
2020-08-12-214801_536x539_scrot

@auouymous
Copy link
Contributor

Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots.

@BuckarooBanzay
Copy link
Member

Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots.

can't this be done in another PR? This one is about translations only.

@louisroyer louisroyer mentioned this pull request Aug 13, 2020
Open
@louisroyer
Copy link
Contributor Author

can't this be done in another PR? This one is about translations only.

ok, I created a new issue #562 and will fix this in another PR.

@BuckarooBanzay BuckarooBanzay mentioned this pull request Oct 28, 2020
Open
5 tasks
@louisroyer
Use MT-5 translation system for concrete mod
7317fc0
@louisroyer
Use MT-5 translation system for extranodes mod
f63f0a2
@louisroyer
Use MT-5 translation system for chests mod
25eb55f
@louisroyer
Use MT-5 translation system for cnc mod
9f0ee21
@louisroyer
Use MT-5 translation system for worldgen mod
8cb5551
@louisroyer
Use MT-5 translation system for wrench mod
2d61270
@louisroyer
Use MT-5 translation system for technic mod
dc0fe35
@louisroyer
Remove translation strings from minetest.log output and from `print…
fcbc7ec 
…()` output

Since they are not translated anyway.
@louisroyer
Fix translation of iron
8c7e636 
And preserve compatibility with [toolranks
mod](https://github.com/lisacvuk/minetest-toolranks/).
@louisroyer
Fix translation of wrought iron blocks
026c1ae 
Note: nodes to convert from steel blocks to wroughtiron blocks now
require to be added manually since doing this automatically breaks
translations.
@louisroyer
Fix crash when switching station is placed
946f540
@louisroyer
Removes depends.txt
c2f02dc
@louisroyer
Add min minetest version
a104c14
@louisroyer
Add toolranks in luacheckrc && update to toolranks 1.2 api
08343b1
@louisroyer
Fix luacheck syntax warnings
0878430
@louisroyer
Copy link
Contributor Author

Rebased and removed unused/duplicates translations.

@OgelGames OgelGames mentioned this pull request Jun 9, 2022
Open
5 tasks
@SmallJoker
Copy link
Member

SmallJoker commented Jun 9, 2022 •
edited
Loading

Sorry, I didn't remember there was a PR to change the translation system.

Would you - at any chance - have time to rebase this PR? To reduce additional work, it might make sense to reorder and squash related commits using git rebase -i HEAD~20. Also feel free to open a PR per mod, if you'd prefer to split the work.

EDIT:

Note: some strings on battery box nodes overflow the formspec

Yes, I am aware of that, but fixing it belongs to another PR.

@louisroyer
Copy link
Contributor Author

I will try to have a look at this before the end of the month.

@SmallJoker
Copy link
Member

@louisroyer Would you like to continue on this PR sometime?

@SmallJoker SmallJoker mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louisroyer @auouymous @BuckarooBanzay @SmallJoker