Replace deprecated 'intllib' function: #382
Conversation
concrete/init.lua
Outdated
| @@ -5,7 +5,7 @@ local technic = rawget(_G, "technic") or {} | |||
| technic.concrete_posts = {} | |||
|
|
|||
| -- Boilerplate to support localized strings if intllib mod is installed. | |||
| local S = rawget(_G, "intllib") and intllib.Getter() or function(s) return s end | |||
| local S = rawget(_G, "intllib") and intllib.make_gettext_pair() or intllib.Getter() or function(s) return s end | |||
There was a problem hiding this comment.
rawget(_G, "intllib") and (intllib.make_gettext_pair() or intllib.Getter()) or function(s) return s end
or
minetest.global_exists("intllib") and (intllib.make_gettext_pair() or intllib.Getter()) or function(s) return s end
or better something not that complicated
There was a problem hiding this comment.
Oh jeez, I can't believe I forgot the braces. 🙄
AntumDeluge
force-pushed
the
intllib_update
branch
from
d4a9071
to
72cc0cf
Compare
|
How is that? |
|
Would it be better to replace |
@AntumDeluge no, conditional statements are better. What I suggested is wrong: braces per se can’t help if |
AntumDeluge
force-pushed
the
intllib_update
branch
from
72cc0cf
to
9c5cd6c
Compare
concrete/init.lua
Outdated
| @@ -5,7 +5,7 @@ local technic = rawget(_G, "technic") or {} | |||
| technic.concrete_posts = {} | |||
|
|
|||
| -- Boilerplate to support localized strings if intllib mod is installed. | |||
| local S = rawget(_G, "intllib") and intllib.Getter() or function(s) return s end | |||
| local S = rawget(_G, "intllib") and (intllib.make_gettext_pair() or intllib.Getter()) or function(s) return s end | |||
There was a problem hiding this comment.
This does not do what it should (see numberZero's comment). Just use intllib.make_gettext_pair() everywhere (exists for an entire year already). Do not support legacy code and let them update their outdated mods.
technic/machines/MV/lighting.lua
Outdated
| @@ -7,7 +7,11 @@ | |||
| local S | |||
| if (minetest.get_modpath("intllib")) then | |||
| dofile(minetest.get_modpath("intllib").."/intllib.lua") | |||
| S = intllib.Getter(minetest.get_current_modname()) | |||
| if (intllib.make_gettext_pair) then | |||
There was a problem hiding this comment.
S = technic.getter or am I missing something?
...intllib'make_gettext_pair.
AntumDeluge
force-pushed
the
intllib_update
branch
from
9c5cd6c
to
cd6ed58
Compare
|
It's been a while. I hope that is what you were looking for. Let me know if I misunderstood anything please. |
|
Closing in favour of #529 |
otherwise use deprecated function.