Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 三期型、四期型 #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update 三期型、四期型 #172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65d830d
remove 三期型、四期型
NullYing Apr 17, 2020
a0f6ad9
更新翻译
NullYing Apr 18, 2020
7c59514
update zh.json
NullYing Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"decreasing": "递减型",
"fluctuating": "波动型",
"unknown": "不知道",
"large-spike": "大幅上涨（三期型）",
"small-spike": "小幅上涨（四期型）"
"large-spike": "大幅上涨",
"small-spike": "小幅上涨"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"large-spike": "大幅上涨",
"small-spike": "小幅上涨"
"large-spike": "三期型",
"small-spike": "四期型"

In fact, I think it would be better to use 三期型 and 四期型 (Remove 大幅上涨 and 小幅上涨).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无法理解啥是三期型四期型，可以麻烦解释一下？对于普通人来说，跟我一样有疑问的会有更多

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无法理解啥是三期型四期型，可以麻烦解释一下？对于普通人来说，跟我一样有疑问的会有更多

简单来说，三期型上涨三次，四期型上涨四次。
#166

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那么我觉得可以翻译成这样，而不是简单的三期型和四期型

三期型（上涨三次）
四期型（上涨四次）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不经过解释的话，很多人都不会知道这两词的意思

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It maybe better? It's too difficult

大幅上涨三次
小幅上涨四次

三期型（大幅上涨三次）
四期型（小幅上涨四次）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It maybe better? It's too difficult
大幅上涨三次
小幅上涨四次

三期型（大幅上涨三次）
四期型（小幅上涨四次）

It's too many word

Copy link
Contributor

@DevSplash DevSplash Apr 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to explain the patterns by adding title attribute.
(Or add mouse hover tips in other ways)

Copy link
Contributor Author

@NullYing NullYing Apr 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 大幅上涨三次 and 小幅上涨四次 is enough to explain, and it easier for regular people to understand.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue open #41 for adding tooltip/hover that explains how the pattern works.

The idea behind the title is to give a simple name that explains that overall result of the pattern, not each phase of that pattern.

For example, "large spike" means the overall result is a big increase in sell price, but doesn't indicate how many periods the increase will last.

},
"prices": {
"description": "本周你的岛上大头菜的购买价格是多少？<i>（如果你是第一次购买大头菜，这个字段不可用）</i>",
Expand All @@ -42,15 +42,15 @@
"wednesday": "周三",
"thursday": "周四",
"friday": "周五",
"saturday" : "周六",
"saturday": "周六",
"sunday": "周日",
"abr": {
"monday": "周一",
"tuesday": "周二",
"wednesday": "周三",
"thursday": "周四",
"friday": "周五",
"saturday" : "周六"
"saturday": "周六"
}
},
"times": {
Expand All @@ -77,4 +77,4 @@
"contributors-text": "哦！别忘记感谢那些至今为止做出过贡献的人。",
"contributors": "贡献者"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should have new line at end of file.

12 changes: 6 additions & 6 deletions locales/zh-TW.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
"pattern": "模型",
"all": "所有模型",
"decreasing": "遞減型",
"fluctuating": "波型",
"fluctuating": "波動型",
"unknown": "不知道",
"large-spike": "三期型",
"small-spike": "四期型"
"large-spike": "大幅上漲",
"small-spike": "小幅上漲"
NullYing marked this conversation as resolved.
Show resolved Hide resolved
},
"prices": {
"description": "本週大頭菜的購買價格是多少？<i>(如果這是您第一次購買大頭菜，則此欄位會被停用)</i>",
Expand All @@ -42,15 +42,15 @@
"wednesday": "星期三",
"thursday": "星期四",
"friday": "星期五",
"saturday" : "星期六",
"saturday": "星期六",
"sunday": "星期日",
"abr": {
"monday": "週一",
"tuesday": "週二",
"wednesday": "週三",
"thursday": "週四",
"friday": "週五",
"saturday" : "週六"
"saturday": "週六"
}
},
"times": {
Expand All @@ -77,4 +77,4 @@
"contributors-text": "哦！讓我們不要忘記感謝那些迄今為止作出貢獻的人！",
"contributors": "貢獻者"
}
}
}