Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 三期型、四期型 #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

NullYing
Copy link
Contributor

#165 (comment)

Would recommend dropping the (四期型) and (三期型) off these translations. Those suggest a numerical order ot the patterns that both does not map to the order the buttons appear on the website, and possibly worse they also don't match up to their in-game pattern number which would likely end up confusing people who are familiar with the extracted game code.

@NullYing NullYing changed the title dropping 三期型、四期型 drop 三期型、四期型 Apr 17, 2020
theRTC204
theRTC204 previously approved these changes Apr 17, 2020
Copy link
Collaborator

@theRTC204 theRTC204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

Comment on lines 25 to 26
"large-spike": "大幅上涨",
"small-spike": "小幅上涨"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"large-spike": "大幅上涨",
"small-spike": "小幅上涨"
"large-spike": "三期型",
"small-spike": "四期型"

In fact, I think it would be better to use 三期型 and 四期型 (Remove 大幅上涨 and 小幅上涨).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无法理解啥是三期型四期型,可以麻烦解释一下?对于普通人来说,跟我一样有疑问的会有更多

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无法理解啥是三期型四期型,可以麻烦解释一下?对于普通人来说,跟我一样有疑问的会有更多

简单来说,三期型上涨三次,四期型上涨四次。
#166

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那么我觉得可以翻译成这样,而不是简单的三期型和四期型

三期型(上涨三次)
四期型(上涨四次)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不经过解释的话,很多人都不会知道这两词的意思

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It maybe better? It's too difficult

大幅上涨三次
小幅上涨四次

三期型(大幅上涨三次)
四期型(小幅上涨四次)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It maybe better? It's too difficult
大幅上涨三次
小幅上涨四次

三期型(大幅上涨三次)
四期型(小幅上涨四次)

It's too many word

Copy link
Contributor

@DevSplash DevSplash Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to explain the patterns by adding title attribute.
(Or add mouse hover tips in other ways)

Copy link
Contributor Author

@NullYing NullYing Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 大幅上涨三次 and 小幅上涨四次 is enough to explain, and it easier for regular people to understand.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue open #41 for adding tooltip/hover that explains how the pattern works.

The idea behind the title is to give a simple name that explains that overall result of the pattern, not each phase of that pattern.

For example, "large spike" means the overall result is a big increase in sell price, but doesn't indicate how many periods the increase will last.

locales/zh-TW.json Outdated Show resolved Hide resolved
DevSplash
DevSplash previously approved these changes Apr 18, 2020
@NullYing NullYing changed the title drop 三期型、四期型 update 三期型、四期型 Apr 18, 2020
@peter50216
Copy link
Contributor

There was a discussion about this on discord yesterday, and I think the conclusion was that we can use the "三期型" "四期型" as pattern names since they're somewhat commonly referred pattern names in many Chinese articles about turnips, and rely on #41 to have a proper solution on explaining the pattern meaning clearly.

@theRTC204
Copy link
Collaborator

Yes, ideally we would use a term that is common in the native language as a simple title of the pattern, and then when we add the tooltips that better explain the behavior of the patterns we will localize that information as well.

@NullYing
Copy link
Contributor Author

Yes, ideally we would use a term that is common in the native language as a simple title of the pattern, and then when we add the tooltips that better explain the behavior of the patterns we will localize that information as well.

"三期型" "四期型" is’t common in the native language as a simple, He just appeared in an analyzed article only. After all, people have preconceived habits.

@mikebryant
Copy link
Owner

What's the status of this? I don't understand the language or the discussion here, so I'm a bit in the dark :p

Copy link
Contributor

@peter50216 peter50216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer using the shorter and more "common" (in the AC community) term (三期型, 四期型) and have #41 to have a full description on how each pattern actually looks like.

Another nit pick on the PR's translation is that "大幅上漲三次" and "小幅上漲四次" isn't actually describing the pattern clearly since there's only one "large" increase in the large-spike pattern, but the translation makes it looks like there are three large increases.

So my personal preference for this is:

  1. "三期型" / "四期型" with Tooltip descriptions for pattern names #41
  2. "大幅上涨(三期型)" / "小幅上涨(四期型)" (Additional bonus for this is this also align with the Japanese translation)
  3. "大幅上涨" / "小幅上涨"
  4. "三期型" / "四期型" without Tooltip descriptions for pattern names #41
  5. "大幅上漲三次" / "小幅上漲四次"

@@ -77,4 +77,4 @@
"contributors-text": "哦!别忘记感谢那些至今为止做出过贡献的人。",
"contributors": "贡献者"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should have new line at end of file.

@theRTC204
Copy link
Collaborator

theRTC204 commented Apr 25, 2020

I don't speak the language either, but Google seems to agree with @peter50216 in that it suggests the translation is "soars three times". If that is actually the translation, then it is an incorrect way to describe the pattern.

@KKKKaiZhu
Copy link
Contributor

KKKKaiZhu commented Apr 26, 2020

"大幅上涨" / "小幅上涨" makes more sense to me, and I think it will be more intuitive to most people.
Don't think many player (including me!) have a good understanding to "三期型" / "四期型".
"大幅上漲三次" and "小幅上漲四次" are inaccurate because the pattern doesn't actually "soars 3 times" or "rises 4 times".

@yuxincs
Copy link

yuxincs commented Apr 28, 2020

Don't think many player (including me!) have a good understanding to "三期型" / "四期型".

I second that. In fact, I believe we should assume the opposite, especially for the new players that just started on AC:NH.

My personal preference is that we should make the name as simple as possible (therefore "大幅上涨" / "小幅上涨"), and let the tooltips do everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants