-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative contribution of custom Tree Explorer #14048
Merged
+1,214
−37
Merged
Changes from 1 commit
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
2657a9d
Add contributes.explorer section and add it to ViewletRegistry
octref aa1ffcd
Add icon to activity bar (loaded separately than stock Viewlets)
octref c2bdd6a
Refactor and put id as property of TreeContentProvider
octref d03ea81
Make TreeViewlet render correctly
octref d8c0af7
Hook up provider mechanism and add onClick
octref 5276b19
Clean up
octref 8081e2e
async loading children
octref 10af4d7
Add click behavior to Controller
octref 6f4de8b
Remove isChildrenResolved from ITreeNode
octref 61639c0
Clean up
octref c8bbaaa
Remove JSON as ITreeNode is all primitives
octref f364538
Reduce calls to refresh tree to one call
octref 154cdf9
Keep a local tree at extHostExplorer side
octref ec1cc0d
Better naming and some doc
octref e88e3f0
More consistent naming and clean up random strings
octref 373829a
Allow tree label to be set
octref 7f5e03f
Avoid same order for multiple viewlets
octref 230ac46
Allow icon to be set via explorer contribution
octref eced815
Descriptor id needs to correspond to Viewlet's
octref 8e9982c
isExpanded -> shouldInitiallyExpand
octref fb032eb
Remove unused go outline stuff
octref 29c03ea
Remove children on ExtHost side and refactor
octref f366857
Completely remove children
octref 09703d2
Add initial onClickCommand
octref c7f2d3d
Resolving onClickCommand and clean up
octref 30e3be2
Rename treeContentProviderId to treeExplorerNodeProviderId
octref b8ce9ad
Make nodeProvider generic and add contentProvider
octref 668aa65
onClickCommand -> clickCommand
octref f660ca6
Update API
octref f659fdd
Add actions
octref 6bb8278
Hook up hasChildren
octref b474369
Give default value to label, hasChildren, etc
octref 0cc3fec
Placeholder for toggle external actions
octref c24338d
Fix API
octref af5af72
Accomondate new non-promise provideRootNode etc
octref 6300fbf
Remove unused svg files
octref 13d5690
Add license
octref 4eab0df
Split explorer's extension point to a separate file
octref 944101c
Let ViewletRegistry handle batch registration and notify ActivityBarPart
octref 1c28702
Read config from global storage
octref 940a7fa
Only display whitelisted viewlet icons on activity bar
octref 2e0f8d0
Populate command with enabled/disabled viewlets
octref 1364159
Retrieve list of registered viewletes to populate toggle custom explo…
octref 88e869a
Refactor activitybar and clean up
octref 0031078
Clean up
octref 0471662
Add back pre-commit hygiene
octref 5b1ba3c
Fix lint error
octref 31afc03
Clean up format issues
octref 09eebc5
Use providerId instead of 'pineTree'!
octref 857411d
Make naming consistent
octref 0c18979
Handle errors caused by provider
octref 045aedd
ContentProvider -> TreeExplorerNodeProvider
octref f19446e
Avoid re-rendering the tree when icon is clicked
octref ec7f077
Naming
octref 7750596
Remove shouldInitiallyExpand
octref c49e7bc
Fix active viewlet highlighting and double click hide for sidebar
octref 7642976
Open file explorer if last viewlet before close is external
octref b654b53
Update doc
octref 4cc76f5
Remember order of external viewlets
octref 16dd5f9
Clean up
octref 313df77
Polish doc language
octref b141507
Minor clean up
octref 6fd1c54
Move VIEWLET_ID_ROOT to one place
octref 267aab6
Correct ID for toggle action
octref 6e868d6
Add refresh button to toolBar
octref a5adf50
Always preserve stock viewlets order
octref d579cb8
Hook refresh button to update input
octref 0b84a56
Consistent naming
octref 37398ea
Handle all error by showing message
octref bc573a7
Let user contributed explorer icon be a string
octref 0e9aecd
Clarify some code
octref 60574ba
Add progress indication for long running resolveChildren
octref a21ac50
Fix use before initialization
octref 39ecfd3
Restore external viewlet on startup
octref e2f4a6b
Coerce external viewlet icons into style similar to stock ones
octref 794ad90
Address feedback
octref 8f777ab
Merge remote-tracking branch 'origin/master' into treeExplorerAPI
octref 4ed359a
Update dts doc
octref a3d577c
Address feedback
octref a196d7f
Move static css rules to css file
octref 70be684
Use treeLabel in toggle command
octref f5d4ede
Merge remote-tracking branch 'origin/master' into treeExplorerAPI
octref 09c11fe
Move API to proposed dts
octref f18fa6e
Fix build error
octref c476937
Set registerTreeExplorerNodeProvider as proposed API
octref 31960a7
Move error handling to main side
octref 84dd43b
Execute onClickCommand on Main side
octref a52cfbb
Move explorerExtensionPoint from platform to workbench
octref d153d96
Display external viewlets on all extensions loaded
octref 894c3cf
Refactor and consistent naming
octref 355f115
Use JSON/interface over the wire
octref 1ed2912
Clean up unused external viewlet order
octref 68284bb
Access modifiers
octref a04f317
Merge remote-tracking branch 'upstream/master' into treeExplorerAPI
bpasero 4660455
Move explorer entry point to parts/explorers
octref 50eb471
External Viewlet -> ExtViewlet
octref 3870173
Put actions for tree explorers to common layer
octref a6f8b94
nls and consistent naming for toggle tree explorer action
octref 3b5e3ea
Clean up treeExplorer's ID
octref 9cf01e8
For the sake of browser compatibility and linting
octref b205a4c
Vertical centering text in tree item label
octref 1cdbe70
Make activity bar icon class unique
octref 13f2dad
Validate user provided viewletId
octref 5342705
Better naming
octref 65f43cc
nls
octref 347c2e9
External -> Extension
octref ff63a4d
Merge remote-tracking branch 'origin/master' into treeExplorerAPI
octref 11486b8
Rename confusing service
octref 29346ad
Merge remote-tracking branch 'origin/master' into treeExplorerAPI
octref 307037c
Add ViewletService as IViewletService
octref 15bf2ec
Put Viewlet related things to ViewletService
octref e2b7b52
Restore enable/disable extensions & preserve enabling order
octref 6793e08
Remove awkward workaround for extension viewletid
octref c57973f
Remove unused event
octref 85f4204
Fix restoring last viewlet
octref 0b15cbb
Preserve badge on add/remove viewlet
octref b9cf15d
Merge remote-tracking branch 'upstream/master' into treeExplorerAPI
octref 902137c
Fix compile error, will write test later
octref 06b82f5
Split didExtensionViewletLoad from didViewletToggle
octref 4d25517
Open viewlet/switch to default viewlet when toggling extension
octref dd19d59
Various cleanup
octref d111426
Naming
octref 25885c6
Remove unused services
octref 80a0cbf
Naming and clean up
octref ae720e9
Merge remote-tracking branch 'upstream/master' into treeExplorerAPI
octref a585a33
Move viewlet restore logic to viewletService
octref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Give default value to label, hasChildren, etc
- Loading branch information
commit b474369a9e3a8e7f19f8d289c6d838e3dfeb36d2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this default to
'label'
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot, sorry.