-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative contribution of custom Tree Explorer #14048
Changes from 1 commit
2657a9d
aa1ffcd
c2bdd6a
d03ea81
d8c0af7
5276b19
8081e2e
10af4d7
6f4de8b
61639c0
c8bbaaa
f364538
154cdf9
ec1cc0d
e88e3f0
373829a
7f5e03f
230ac46
eced815
8e9982c
fb032eb
29c03ea
f366857
09703d2
c7f2d3d
30e3be2
b8ce9ad
668aa65
f660ca6
f659fdd
6bb8278
b474369
0cc3fec
c24338d
af5af72
6300fbf
13d5690
4eab0df
944101c
1c28702
940a7fa
2e0f8d0
1364159
88e869a
0031078
0471662
5b1ba3c
31afc03
09eebc5
857411d
0c18979
045aedd
f19446e
ec7f077
7750596
c49e7bc
7642976
b654b53
4cc76f5
16dd5f9
313df77
b141507
6fd1c54
267aab6
6e868d6
a5adf50
d579cb8
0b84a56
37398ea
bc573a7
0e9aecd
60574ba
a21ac50
39ecfd3
e2f4a6b
794ad90
8f777ab
4ed359a
a3d577c
a196d7f
70be684
f5d4ede
09c11fe
f18fa6e
c476937
31960a7
84dd43b
a52cfbb
d153d96
894c3cf
355f115
1ed2912
68284bb
a04f317
4660455
50eb471
3870173
a6f8b94
3b5e3ea
9cf01e8
b205a4c
1cdbe70
13f2dad
5342705
65f43cc
347c2e9
ff63a4d
11486b8
29346ad
307037c
15bf2ec
e2b7b52
6793e08
c57973f
85f4204
0b15cbb
b9cf15d
902137c
06b82f5
4d25517
dd19d59
d111426
25885c6
80a0cbf
ae720e9
a585a33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- vsda-v1.39.1
- v14
- v1.19.3
- translation/20172701.01
- translation/20170407.01
- translation/20170331.01
- translation/20170324.01
- translation/20170317.01
- translation/20170311.01
- translation/20170227.01
- translation/20170217.01
- translation/20170203.01
- translation/20170127.01
- translation/20170123.01
- translation/20161209.01
- translation/20161125.01
- translation/20161118.01
- translation/20161111.01
- release/1.46.0
- release/1.46
- master-with-conflict-190418
- bad3
- bad2
- GOOD
- BAD
- 1.96.4
- 1.96.3
- 1.96.2
- 1.96.1
- 1.96.0
- 1.95.3
- 1.95.2
- 1.95.1
- 1.95.0
- 1.94.2
- 1.94.1
- 1.94.0
- 1.93.1
- 1.93.0
- 1.92.2
- 1.92.1
- 1.92.0
- 1.91.1
- 1.91.0
- 1.90.2
- 1.90.1
- 1.90.0
- 1.89.1
- 1.89.0
- 1.88.1
- 1.88.0
- 1.87.2
- 1.87.1
- 1.87.0
- 1.86.2
- 1.86.1
- 1.86.0
- 1.85.2
- 1.85.1
- 1.85.0
- 1.84.2
- 1.84.1
- 1.84.0
- 1.83.1
- 1.83.0
- 1.82.3
- 1.82.2
- 1.82.1
- 1.82.0
- 1.81.1
- 1.81.0
- 1.80.2
- 1.80.1
- 1.80.0
- 1.79.2
- 1.79.1
- 1.79.0
- 1.78.2
- 1.78.1
- 1.78.0
- 1.77.3
- 1.77.2
- 1.77.1
- 1.77.0
- 1.76.2
- 1.76.1
- 1.76.0
- 1.75.1
- 1.75.0
- 1.74.3
- 1.74.2
- 1.74.1
- 1.74.0
- 1.73.1
- 1.73.0
- 1.72.2
- 1.72.1
- 1.72.0
- 1.71.2
- 1.71.1
- 1.71.0
- 1.70.2
- 1.70.1
- 1.70.0
- 1.69.2
- 1.69.1
- 1.69.0
- 1.68.1
- 1.68.0
- 1.67.2
- 1.67.1
- 1.67.0
- 1.66.2
- 1.66.1
- 1.66.0
- 1.65.2
- 1.65.1
- 1.65.0
- 1.64.2
- 1.64.1
- 1.64.0
- 1.63.2
- 1.63.1
- 1.63.0
- 1.62.3
- 1.62.2
- 1.62.1
- 1.62.0
- 1.61.2
- 1.61.1
- 1.61.0
- 1.60.2
- 1.60.1
- 1.60.0
- 1.59.1
- 1.59.0
- 1.58.2
- 1.58.1
- 1.58.0
- 1.57.1
- 1.57.0
- 1.56.2
- 1.56.1
- 1.56.0
- 1.55.2
- 1.55.1
- 1.55.0
- 1.54.3
- 1.54.2
- 1.54.1
- 1.54.0
- 1.53.2
- 1.53.1
- 1.53.0
- 1.52.1
- 1.52.0
- 1.51.1
- 1.51.0
- 1.50.1
- 1.50.0
- 1.49.3
- 1.49.2
- 1.49.1
- 1.49.0
- 1.48.2
- 1.48.1
- 1.48.0
- 1.47.3
- 1.47.2
- 1.47.1
- 1.47.0
- 1.46.1
- 1.46.0
- 1.45.1
- 1.45.0
- 1.44.2
- 1.44.1
- 1.44.0
- 1.43.2
- 1.43.1
- 1.43.0
- 1.42.1
- 1.42.0
- 1.41.1
- 1.41.0
- 1.40.2
- 1.40.1
- 1.40.0
- 1.39.2
- 1.39.1
- 1.39.0
- 1.38.1
- 1.38.0
- 1.37.1
- 1.37.0
- 1.36.1
- 1.36.0
- 1.35.1
- 1.35.0
- 1.34.0
- 1.33.1
- 1.33.0
- 1.32.3
- 1.32.2
- 1.32.1
- 1.32.0
- 1.31.1
- 1.31.0
- 1.30.2
- 1.30.1
- 1.30.0
- 1.29.1
- 1.29.0
- 1.28.2
- 1.28.1
- 1.28.0
- 1.27.2
- 1.27.1
- 1.27.0
- 1.26.1
- 1.26.0
- 1.25.1
- 1.25.0
- 1.24.1
- 1.24.0
- 1.23.1
- 1.23.0
- 1.22.2
- 1.22.1
- 1.22.0
- 1.21.1
- 1.21.0
- 1.20.1
- 1.20.0
- 1.19.3
- 1.19.2
- 1.19.1
- 1.19.0
- 1.18.1
- 1.18.0
- 1.17.2
- 1.17.1
- 1.17.0
- 1.16.1
- 1.16.0
- 1.15.1
- 1.15.0
- 1.14.2
- 1.14.1
- 1.14.0
- 1.13.1
- 1.13.0
- 1.12.2
- 1.12.1
- 1.12.0
- 1.11.2
- 1.11.1
- 1.11.0
- 1.10.2
- 1.10.1
- 1.10.0
- 1.9.1
- 1.9.0
- 1.8.1
- 1.8.0
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,13 +29,13 @@ export class ToggleExternalViewletAction extends Action { | |
} | ||
|
||
run(): TPromise<any> { | ||
const viewletsToggleStataus = this.activityService.getRegisteredViewletsToggleStatus(); | ||
const viewletsToggleStataus = this.activityService.getRegisteredViewletsIsEnabled(); | ||
|
||
const picks: IPickOpenEntry[] = []; | ||
for (let viewletId in viewletsToggleStataus) { | ||
picks.push({ | ||
id: viewletId, | ||
label: (viewletsToggleStataus[viewletId] ? "Disable " : "Enable ") + this.getShortViewletId(viewletId) | ||
label: (viewletsToggleStataus[viewletId] ? 'Disable ' : 'Enable ') + this.getShortViewletId(viewletId) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good. Will do. |
||
}); | ||
} | ||
|
||
|
@@ -55,6 +55,6 @@ export class ToggleExternalViewletAction extends Action { | |
|
||
registry.registerWorkbenchAction( | ||
new SyncActionDescriptor(ToggleExternalViewletAction, ToggleExternalViewletAction.ID, ToggleExternalViewletAction.LABEL), | ||
"View: Toggle Custom Explorer", | ||
'View: Toggle Custom Explorer', | ||
nls.localize('view', "View") | ||
); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,17 +72,17 @@ export interface IActivityService { | |
clearActivity(compositeId: string): void; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @octref this Viewlet related code should move into |
||
/** | ||
* Get all registered viewlets and whether they are enabled/disabled | ||
* Get all registered viewlets and whether they are enabled/disabled. | ||
*/ | ||
getRegisteredViewletsToggleStatus(): { [viewletId: string]: boolean }; | ||
getRegisteredViewletsIsEnabled(): { [viewletId: string]: boolean }; | ||
|
||
/** | ||
* Enable/disable viewlet | ||
* Enable/disable viewlet. | ||
*/ | ||
toggleViewlet(viewletId: string): void; | ||
|
||
/** | ||
* Get the external viewlet id to open | ||
* Get the external viewlet id that is about to open. | ||
*/ | ||
getExternalViewletIdToOpen(): string; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add access modifier