Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new container client package #3982

Merged
merged 11 commits into from
Jul 25, 2023
11 changes: 10 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3033,6 +3033,7 @@
"@microsoft/vscode-azext-azureappservice": "^1.0.2",
"@microsoft/vscode-azext-azureutils": "^1.1.5",
"@microsoft/vscode-azext-utils": "^1.2.2",
"@microsoft/vscode-container-client": "^0.1.0",
"dayjs": "^1.11.7",
"dockerfile-language-server-nodejs": "^0.10.2",
"fs-extra": "^11.1.1",
Expand All @@ -3041,7 +3042,6 @@
"node-fetch": "^2.6.9",
"semver": "^7.5.2",
"tar": "^6.1.13",
"tree-kill": "^1.2.2",
"vscode-languageclient": "^8.1.0",
"vscode-tas-client": "^0.1.63",
"xml2js": "^0.5.0"
Expand Down
2 changes: 1 addition & 1 deletion src/commands/containers/attachShellContainer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext } from '@microsoft/vscode-azext-utils';
import { ContainerOS, VoidCommandResponse } from '@microsoft/vscode-container-client';
import { l10n } from 'vscode';
import { ext } from '../../extensionVariables';
import { ContainerOS, VoidCommandResponse } from '../../runtimes/docker';
import { TaskCommandRunnerFactory } from '../../runtimes/runners/TaskCommandRunnerFactory';
import { ContainerTreeItem } from '../../tree/containers/ContainerTreeItem';
import { getDockerOSType } from '../../utils/osUtils';
Expand Down
2 changes: 1 addition & 1 deletion src/commands/containers/browseContainer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* Licensed under the MIT License. See LICENSE.md in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { PortBinding } from '../../runtimes/docker';
import { IActionContext, IAzureQuickPickItem, TelemetryProperties } from '@microsoft/vscode-azext-utils';
import { PortBinding } from '@microsoft/vscode-container-client';
import * as vscode from 'vscode';
import { ext } from "../../extensionVariables";
import { ContainerTreeItem } from "../../tree/containers/ContainerTreeItem";
Expand Down
2 changes: 1 addition & 1 deletion src/commands/containers/composeGroup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext } from '@microsoft/vscode-azext-utils';
import { CommonOrchestratorCommandOptions, IContainerOrchestratorClient, LogsCommandOptions, VoidCommandResponse } from '@microsoft/vscode-container-client';
import * as path from 'path';
import { l10n } from 'vscode';
import { ext } from '../../extensionVariables';
import { CommonOrchestratorCommandOptions, IContainerOrchestratorClient, LogsCommandOptions, VoidCommandResponse } from '../../runtimes/docker';
import { TaskCommandRunnerFactory } from '../../runtimes/runners/TaskCommandRunnerFactory';
import { ContainerGroupTreeItem } from '../../tree/containers/ContainerGroupTreeItem';
import { ContainerTreeItem } from '../../tree/containers/ContainerTreeItem';
Expand Down
2 changes: 1 addition & 1 deletion src/commands/images/runAzureCliImage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
*--------------------------------------------------------------------------------------------*/

import { DialogResponses, IActionContext } from '@microsoft/vscode-azext-utils';
import { RunContainerBindMount } from '@microsoft/vscode-container-client';
import * as fse from 'fs-extra';
import * as os from 'os';
import * as path from 'path';
import * as vscode from 'vscode';
import { l10n } from 'vscode';
import { ext } from '../../extensionVariables';
import { RunContainerBindMount } from '../../runtimes/docker';
import { TaskCommandRunnerFactory } from '../../runtimes/runners/TaskCommandRunnerFactory';
import { getDockerOSType } from '../../utils/osUtils';

Expand Down
2 changes: 1 addition & 1 deletion src/commands/registries/azure/deployImageToAca.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext, nonNullProp, UserCancelledError } from '@microsoft/vscode-azext-utils';
import { parseDockerLikeImageName } from '@microsoft/vscode-container-client';
import * as semver from 'semver';
import * as vscode from 'vscode';
import { ext } from '../../../extensionVariables';
import { parseDockerLikeImageName } from '../../../runtimes/docker/clients/DockerClientBase/parseDockerLikeImageName';
import { AzureRegistryTreeItem } from '../../../tree/registries/azure/AzureRegistryTreeItem';
import { DockerHubNamespaceTreeItem } from '../../../tree/registries/dockerHub/DockerHubNamespaceTreeItem';
import { registryExpectedContextValues } from '../../../tree/registries/registryContextValues';
Expand Down
2 changes: 1 addition & 1 deletion src/commands/selectCommandTemplate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext, IAzureQuickPickItem, IAzureQuickPickOptions, UserCancelledError } from '@microsoft/vscode-azext-utils';
import { PortBinding, VoidCommandResponse } from '@microsoft/vscode-container-client';
import * as vscode from 'vscode';
import { ext } from '../extensionVariables';
import { PortBinding, VoidCommandResponse } from '../runtimes/docker';
import { isDockerComposeClient } from '../runtimes/OrchestratorRuntimeManager';
import { resolveVariables } from '../utils/resolveVariables';

Expand Down
2 changes: 1 addition & 1 deletion src/debugging/netcore/NetCoreDebugHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
*--------------------------------------------------------------------------------------------*/

import { DialogResponses, IActionContext, UserCancelledError } from '@microsoft/vscode-azext-utils';
import { CommandLineArgs, ContainerOS, VoidCommandResponse, composeArgs, withArg, withQuotedArg } from '@microsoft/vscode-container-client';
import * as fse from 'fs-extra';
import * as path from 'path';
import { DebugConfiguration, MessageItem, ProgressLocation, l10n, window } from 'vscode';
import { ext } from '../../extensionVariables';
import { CommandLineArgs, ContainerOS, VoidCommandResponse, composeArgs, withArg, withQuotedArg } from '../../runtimes/docker';
import { NetCoreTaskHelper, NetCoreTaskOptions } from '../../tasks/netcore/NetCoreTaskHelper';
import { ContainerTreeItem } from '../../tree/containers/ContainerTreeItem';
import { getNetCoreProjectInfo } from '../../utils/netCoreUtils';
Expand Down
2 changes: 1 addition & 1 deletion src/runtimes/ContainerRuntimeManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { DockerClient, IContainersClient } from './docker';
import { DockerClient, IContainersClient } from '@microsoft/vscode-container-client';
import { ContextManager, IContextManager } from './ContextManager';
import { RuntimeManager } from './RuntimeManager';

Expand Down
2 changes: 1 addition & 1 deletion src/runtimes/ContextManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { InspectContextsItem, ListContextItem } from './docker';
import { InspectContextsItem, ListContextItem } from '@microsoft/vscode-container-client';
import * as vscode from 'vscode';
import { ext } from '../extensionVariables';

Expand Down
4 changes: 2 additions & 2 deletions src/runtimes/OrchestratorRuntimeManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { isAutoConfigurableDockerComposeClient } from './clients/AutoConfigurableDockerComposeClient';
import { DockerComposeClient, IContainerOrchestratorClient } from './docker';
import { DockerComposeClient, IContainerOrchestratorClient } from '@microsoft/vscode-container-client';
import { RuntimeManager } from './RuntimeManager';
import { isAutoConfigurableDockerComposeClient } from './clients/AutoConfigurableDockerComposeClient';

export class OrchestratorRuntimeManager extends RuntimeManager<IContainerOrchestratorClient> {
public readonly onOrchestratorRuntimeClientRegistered = this.runtimeClientRegisteredEmitter.event;
Expand Down
2 changes: 1 addition & 1 deletion src/runtimes/RuntimeManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { ClientIdentity } from '@microsoft/vscode-container-client';
import * as vscode from 'vscode';
import { ClientIdentity } from './docker';

export abstract class RuntimeManager<TClient extends ClientIdentity> extends vscode.Disposable {
private readonly _runtimeClients = new Map<string, TClient>();
Expand Down
2 changes: 1 addition & 1 deletion src/runtimes/clients/AutoConfigurableDockerClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { DockerClient } from '@microsoft/vscode-container-client';
import * as vscode from 'vscode';
import { ext } from '../../extensionVariables';
import { DockerClient } from '../docker';
import { AutoConfigurableClient } from './AutoConfigurableClient';

export class AutoConfigurableDockerClient extends DockerClient implements AutoConfigurableClient {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { DockerComposeClient, IContainerOrchestratorClient } from '@microsoft/vscode-container-client';
import * as vscode from 'vscode';
import { ext } from '../../extensionVariables';
import { execAsync } from '../../utils/execAsync';
import { AsyncLazy } from '../../utils/lazy';
import { DockerComposeClient, IContainerOrchestratorClient } from '../docker';
import { isDockerComposeClient } from '../OrchestratorRuntimeManager';
import { AutoConfigurableClient } from './AutoConfigurableClient';

Expand Down
46 changes: 0 additions & 46 deletions src/runtimes/docker/clients/ConfigurableClient.ts

This file was deleted.

Loading