Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new container client package #3982

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Use new container client package #3982

merged 11 commits into from
Jul 25, 2023

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jun 22, 2023 •
edited
Loading

Fixes #3860

@bwateratmsft bwateratmsft added this to the 1.26.0 milestone Jun 22, 2023
@bwateratmsft bwateratmsft requested a review from a team as a code owner June 22, 2023 13:10
bwateratmsft
bwateratmsft commented Jun 22, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/commands/registries/azure/deployImageToAca.ts Outdated Show resolved Hide resolved
X-oss-byte

This comment was marked as off-topic.

Sign in to view

@microsoft microsoft deleted a comment from X-oss-byte Jun 30, 2023
@bwateratmsft bwateratmsft modified the milestones: 1.26.0, 1.27.0 Jul 11, 2023
@bwateratmsft bwateratmsft removed this from the 1.27.0 milestone Jul 17, 2023
@bwateratmsft bwateratmsft mentioned this pull request Jul 21, 2023
Closed
6 tasks
@microsoft microsoft deleted a comment from X-oss-byte Jul 25, 2023
alexyaang
alexyaang approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@alexyaang alexyaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bwateratmsft bwateratmsft merged commit fedf5ba into main Jul 25, 2023
2 checks passed
@bwateratmsft bwateratmsft deleted the bmw/containerClient branch July 25, 2023 16:39
@bwateratmsft bwateratmsft added this to the 1.27.0 milestone Jul 25, 2023
alexyaang pushed a commit that referenced this pull request Aug 1, 2023
@bwateratmsft @alexyaang
Use new container client package (#3982)
6d6f8d9
@microsoft microsoft locked and limited conversation to collaborators Sep 9, 2023
@alexyaang alexyaang removed this from the 1.27.0 milestone Sep 13, 2023
@alexyaang alexyaang added this to the 1.26.1 milestone Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danegsta danegsta danegsta left review comments

@X-oss-byte X-oss-byte X-oss-byte approved these changes

@alexyaang alexyaang alexyaang approved these changes

Assignees
No one assigned
Labels
engineering fix released
Projects
None yet
Milestone
1.26.1
Development

Successfully merging this pull request may close these issues.

Extract docker client as package
4 participants
@bwateratmsft @danegsta @alexyaang @X-oss-byte