Fix CI crash by ensuring the "core" feature is installed for all ports. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So close my PR #327. |
|
I've opened #331 with a more generalized fix and problem explanation. |
|
Closing in favor of #331 |
|
Reopening this because I think it may be more correct and want to further discuss with Robert. |
ras0219-msft
approved these changes
Jan 27, 2022
BillyONeal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the crash/regression in the "ci" command caused by #298
I'm pretty sure this is not a correct fix but it at least makes the ci command seem to match the last known good commit.