-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcpkg-tool to 2022-01-19 #22629
Conversation
The ci command segfaults |
Would be fixed by microsoft/vcpkg-tool#327 |
Ok not completely, it then fails at
|
Right, that change sees when nulls happen and skips over them, but it doesn't fix that nulls got in there in the first place which is the actual bug. It regressed in microsoft/vcpkg-tool#298 and I'm investigating. |
microsoft/vcpkg-tool#329 is my current WIP after spending all day trying to diagnose the issue |
9a495e1
to
bf0e8d1
Compare
Maybe change |
That would trigger a rebuild for customers too which is undesirable. |
I mean you only change it to trigger a full rebuild to test if everything still works. If everything still works you revert the change again. Edit: Otherwise there is only microsoft/vcpkg-tool#310 that could break some ports. No new post build check was introduced. So yeah you maybe don't need to rebuild everything to test this new version. |
Oh, I see. I suppose getting a full run is a good idea. For that I can just trigger a CI run: https://dev.azure.com/vcpkg/public/_build/results?buildId=66773&view=results |
No description provided.