Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg-tool to 2022-01-19 #22629

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Jan 19, 2022
@JonLiu1993 JonLiu1993 self-assigned this Jan 19, 2022
@autoantwort
Copy link
Contributor

The ci command segfaults

@autoantwort
Copy link
Contributor

Would be fixed by microsoft/vcpkg-tool#327

@autoantwort
Copy link
Contributor

Ok not completely, it then fails at

Starting package 4/1734: absent:x64-osx
Building package absent:x64-osx...
-- Using cached rvarago-absent-0.3.1.tar.gz.
-- Extracting source /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/downloads/rvarago-absent-0.3.1.tar.gz
-- Using source at /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/absent/src/0.3.1-40487c5ce5.clean
-- Configuring x64-osx-dbg
-- Configuring x64-osx-rel
-- Building x64-osx-dbg
-- Building x64-osx-rel
-- Installing: /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/absent_x64-osx/share/absent/README.md
-- Installing: /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/absent_x64-osx/share/absent/copyright
-- Performing post-build validation
-- Performing post-build validation done
Error: vcpkg has crashed; no additional details are available.
The source line is /Users/leanderSchulten/git_projekte/vcpkg-tool/src/vcpkg/build.cpp(958)

@BillyONeal BillyONeal marked this pull request as draft January 20, 2022 21:51
@BillyONeal
Copy link
Member Author

Ok not completely, it then fails at

Right, that change sees when nulls happen and skips over them, but it doesn't fix that nulls got in there in the first place which is the actual bug. It regressed in microsoft/vcpkg-tool#298 and I'm investigating.

@BillyONeal
Copy link
Member Author

microsoft/vcpkg-tool#329 is my current WIP after spending all day trying to diagnose the issue

@BillyONeal BillyONeal marked this pull request as ready for review February 1, 2022 01:21
@autoantwort
Copy link
Contributor

Maybe change ports.cmake to trigger a full rebuild

@BillyONeal
Copy link
Member Author

Maybe change ports.cmake to trigger a full rebuild

That would trigger a rebuild for customers too which is undesirable.

@autoantwort
Copy link
Contributor

autoantwort commented Feb 1, 2022

I mean you only change it to trigger a full rebuild to test if everything still works. If everything still works you revert the change again.

Edit: Otherwise there is only microsoft/vcpkg-tool#310 that could break some ports. No new post build check was introduced. So yeah you maybe don't need to rebuild everything to test this new version.

@BillyONeal
Copy link
Member Author

I mean you only change it to trigger a full rebuild to test if everything still works. If everything still works you revert the change again.

Oh, I see. I suppose getting a full run is a good idea. For that I can just trigger a CI run: https://dev.azure.com/vcpkg/public/_build/results?buildId=66773&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants