Upgrade npm dependencies #8506
Merged
Upgrade npm dependencies #8506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riknoll
requested review from
dmonroym,
jwunderl,
abchatra,
eanders-ms,
livcheerful and
shakao
jwunderl
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
LGTM
(for anyone else's ref, here is the link to my old branch https://github.com/microsoft/pxt/commits/updateLess which was just the less changes, I think we landed at pretty much the same point though with a few extra fixes in this change)
shakao
reviewed
Sep 21, 2021
| @@ -17,6 +17,8 @@ | |||
| specify theme name below | |||
| */ | |||
|
|
|||
| @placeholder: 'default'; | |||
There was a problem hiding this comment.
this fixes a build issue with less. tbh, i have no idea what it does but here's where I got it: Semantic-Org/Semantic-UI-LESS#53
shakao
approved these changes
Sep 21, 2021
This was referenced Sep 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading less, semantic-ui-less, karma, and karma-mocha. Once this is merged, I'll go around and do PRs on all the targets with the necessary less changes.
I think I fixed all of the problems with updating semantic-ui-less but we should definitely do some thorough UI testing on this.
Thanks to @jwunderl for reaching into his memory palace and remembering how to fix the less build.