Reset loadFonts() after updated font variable #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanders-ms
approved these changes
Mar 9, 2022
riknoll
pushed a commit
that referenced
this pull request
May 5, 2022
* Refresh pxt-sample * even newer pxt-core * more bluebird removal * Reset loadFonts() after updated font variable (#11) Co-authored-by: shakao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think something about upgrading semantic (microsoft/pxt#8506) also changed the order of our variable overrides, so now
loadFontis being defined before the target setsgoogleFontName... i looked through our changes and i think it must be something inside semantic but i couldn't pinpoint it even after a while of poking around. this fixes it but is not beautiful haha, making it a PR to your PR so you can accept/reject as you see fit