Move iOS package from framework to xcframework #8198
Conversation
|
|
||
| # the actual build process for current arch | ||
| subprocess.run(build_command, shell=False, check=True, cwd=REPO_DIR) | ||
| # subprocess.run(build_command, shell=False, check=True, cwd=REPO_DIR) |
There was a problem hiding this comment.
Uncommented, also removed some other print(...)
| framework_path = os.path.join(c_framework_dir, 'onnxruntime.framework') | ||
| if not pathlib.Path(framework_path).exists(): | ||
| raise FileNotFoundError('{} does not have onnxruntime.framework'.format(c_framework_dir)) | ||
| has_framework = pathlib.Path(os.path.join(c_framework_dir, 'onnxruntime.framework')).exists() |
There was a problem hiding this comment.
For now I don't think cmake can generate xcframework by itself, will still keep the framework for individual ABI, since we will also need it go generate xcframework
| @@ -56,6 +64,7 @@ def _test_ios_packages(args): | |||
|
|
|||
| # replace the target strings | |||
| file_data = file_data.replace('${ORT_BASE_FRAMEWORK_ARCHIVE}', 'file:' + zip_file_path) | |||
| file_data = file_data.replace('${ORT_FRAMEWORK_NAME}', framework_name) | |||
There was a problem hiding this comment.
could potentially specify the local pod directory in the Podfile
https://guides.cocoapods.org/using/the-podfile.html#using-the-files-from-a-folder-local-to-the-machine
then perhaps we could just have one podspec
just an idea - not necessarily for this PR
There was a problem hiding this comment.
Will do in a future PR
|
do these changes work with the iOS packaging pipeline? maybe that will show what objc package changes may be needed. |
|
Opened a new one #8805, closing this one since the code has changed a lot after this PR and it is hard to merge. |
Description: Move iOS package from framework to xcframework
Motivation and Context