Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e tests - Fix continue-as-new #14

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Dec 7, 2023

This PR

  1. improve e2e tests: fix errors, add new tests
  2. Fix continue-as-new hanging issue.

resolving #11

@kaibocai kaibocai marked this pull request as draft December 7, 2023 16:37
@kaibocai kaibocai marked this pull request as ready for review December 7, 2023 18:12
@kaibocai
Copy link
Member Author

kaibocai commented Dec 7, 2023

Hi @davidmrdavid, @cgillum, @torosent, @shubham1172 , would like to get your review on this. My first JS PR so it may have many places to be updated. Appreciate your help!

@kaibocai kaibocai requested a review from cgillum December 7, 2023 18:15
@kaibocai kaibocai mentioned this pull request Dec 7, 2023
@kaibocai kaibocai requested a review from shubham1172 December 7, 2023 18:42
@kaibocai kaibocai merged commit b9a8fc3 into main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant