Purge instance by ID support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibocai
force-pushed
the
kaibocai/purge-instance-support
branch
from
888b9f8 to
fc1e3f8
Compare
shubham1172
reviewed
Dec 13, 2023
| async purgeInstanceById(instanceId: string,): Promise<PurgeResult | undefined> { | ||
| const req = new pb.PurgeInstancesRequest; | ||
| req.setInstanceid(instanceId); | ||
| console.log(`Purging Instance '${instanceId}'`); |
There was a problem hiding this comment.
nit, new line before/after console logs. New line after const prom = promisify... line.
shubham1172
reviewed
Dec 13, 2023
| console.log(`Purging Instance '${instanceId}'`); | ||
| const prom = promisify(this._stub.purgeInstances.bind(this._stub)); | ||
| // Execute the request and wait for the first response or timeout | ||
| const res = (await prom(req)) as pb.PurgeInstancesResponse; |
There was a problem hiding this comment.
Why not create PurgeResult here directly?
shubham1172
reviewed
Dec 13, 2023
| @@ -54,3 +55,15 @@ export function newOrchestrationState( | |||
| failureDetails, | |||
| ); | |||
| } | |||
|
|
|||
| export function newPurgeResult( | |||
There was a problem hiding this comment.
We can remove this if we directly create PurgeResult above.
DeepanshuA
reviewed
Dec 13, 2023
| @@ -191,4 +191,14 @@ export class TaskHubGrpcClient { | |||
| const prom = promisify(this._stub.resumeInstance.bind(this._stub)); | |||
| await prom(req); | |||
| } | |||
|
|
|||
| async purgeInstanceById(instanceId: string,): Promise<PurgeResult | undefined> { | |||
There was a problem hiding this comment.
Should it be purgeOrchestration? in sync with other methods
| @@ -191,4 +191,14 @@ export class TaskHubGrpcClient { | |||
| const prom = promisify(this._stub.resumeInstance.bind(this._stub)); | |||
| await prom(req); | |||
| } | |||
|
|
|||
| expect(state?.instanceId).toEqual(id); | ||
| expect(state?.failureDetails).toBeUndefined(); | ||
| expect(state?.runtimeStatus).toEqual(OrchestrationStatus.ORCHESTRATION_STATUS_COMPLETED); | ||
| expect(state?.serializedInput).toEqual(JSON.stringify(15)); | ||
| expect(state?.serializedOutput).toEqual(JSON.stringify(16)); | ||
| }, 31000); | ||
|
|
||
| it("should be able purge orchestration", async () => { |
There was a problem hiding this comment.
nit typo:
it("should be able to purge orchestration", async () => {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolving #12
Merge order: merge after #14