Add RetryPolicy.Handle Property to Allow for Exception Filtering on Retries

[tomseida]

Add Handle delegate property to RetryPolicy and ensure it is passed to CoreRetryOptions so users of RetryPOlicy have ability to determine retry policy based on exception,

Testing shows it correctly constrains the number of times the task is called, but the check for the number of times the Handle method is called does not meet expectations. The Handle method is being invoked many more times than the task .

[tomseida]

@cgillum, any timeline for reviewing the changes I made based on your comment?

[cgillum]

Just a few small things from me. @jviau, could you take a look as well?

[cgillum]

I'm good with these changes.

[Kobudzik]

Hello, is there any approximate date when will this be released?

[cgillum]

@jviau or @davidmrdavid, when is the next planned release of the .NET Isolated SDK?

[tomseida]

I have been monitoring nuget for updates. Once there is a prerelease, I will perform some additional testing. Also hoping the Schedule orchestration feature fix is also in the next release.

[Fazer01]

Aah, we also would love the feature introduced with this PR. Awaiting new release. Any ETA on this? @jviau @tomseida?

[tomseida]

Aah, we also would love the feature introduced with this PR. Awaiting new release. Any ETA on this? @jviau @tomseida?

I have been checking twice a week to start using these changes. Not sure what's the hold-up. Would think at least a pre-release would be available.

[tomseida]

@cgillum, any update on a release date? Odd that it has been over 3 months since the PR was completed and nothing has been made available.

[cgillum]

I believe @jviau is still on leave until the end of this month. @davidmrdavid, @AnatoliB, or @lilyjma can we come up with a plan for updating the .NET Isolated release in the meantime?

[davidmrdavid]

Should be out now: https://github.com/Azure/azure-functions-durable-extension/releases/tag/v1.1.6-worker-extension

[tomseida]

I tested the new nuget packages and the HandleFailure method worked for me. Thanks for finally get this released. Will save on unnecessary compute.

[Kobudzik]

@cgillum Is there any reason why TaskFailureDetails are used as Func argument? I want to retry on two types of transient errors:

• when SqlServerTransientExceptionDetector.ShouldRetryOn(Exception ex) resolves true
• when exception is ApiException with status code 400/401/404

With current implementation it cannot be achieved as far as I know. Would it make sense to e.g. serialize the original Exception within TaskFailureDetails? Or if TaskFailureDetails shouldn't grow much, maybe there should be some other flow?

durabletask-dotnet/src/Abstractions/RetryPolicy.cs

Line 145 in e0b54b8

public Func<Exception, Task<bool>>? HandleAsync { get; set; }

This non-implemented function would fit more or less on my use case, is there any particular reason why wasn't it implemented?

[cgillum]

Hi @Kobudzik. I think your question(s) might be best to have in a separate GitHub issue since they don’t appear to be simple. Please create an issue and feel free to tag me there. That way we can go into more details without automatically notifying all the participants in this PR.