Add ability to set both RetryPolicy and AsyncRetryHandler

[tomseida]

Add ability to set both RetryPolicy and AsyncRetryHandler for activity functions and suborchestrations.

See Issue #279

[tomseida]

@microsoft-github-policy-service agree

[tomseida]

@microsoft-github-policy-service agree

…

________________________________ From: microsoft-github-policy-service[bot] ***@***.***> Sent: Thursday, April 4, 2024 9:09 AM To: microsoft/durabletask-dotnet ***@***.***> Cc: Tom Seida ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/durabletask-dotnet] Add ability to set both RetryPolicy and AsyncRetryHandler (PR #281) @tomseida<https://github.com/tomseida> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: * (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree * (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. @microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below. 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org<http://www.opensource.org/>). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation. 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project. 3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions. 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions. 5. Licenses. * Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties. * Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project. * Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise. 1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE. 2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect. 3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission. 4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens. 5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft. — Reply to this email directly, view it on GitHub<#281 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIVVFSFLRDWMZC4IIYDJHWLY3VGHJAVCNFSM6AAAAABFXH7BCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGE3TCNJUGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Fazer01]

I'm also awaiting this functionality as we had this in place using the in-process variant. As we use .NET8 and isolated we are unable to use both the policy and retryhandler. It's either the policy or the handler, not both at the moment.

[stevie1706]

We are also waiting for this PR. Can it be reviewed and merged?

[cgillum]

Hi - thanks for this PR!

Question: do you think the RetryPolicy and AsyncRetryHandler need to be combined, or is there a simpler solution where we just have a simple Func<Exception, bool> delegate (non-async) that can be applied to the RetryPolicy?

AsyncRetryHandler is really supposed to be used for advanced scheduling purposes and allows you to do everything a RetryPolicy can do and more. I'd like to keep these separate, if possible, and was hoping maybe you didn't need the full power of AsyncRetryHandler for your use case.

[tomseida]

@cgillum, I have been using orchestrations for about 4 years and using RetryPolicy most of that time. A simple Func<Exception, bool> delegate applied to the RetryPolicy has always sufficed. I would be fine with keep this separate from AsyncRetryHandler.

[stevie1706]

Hi All, Are we able to get this reviewed and merged?

[cgillum]

I'd like us to go with the simpler approach of adding a Func<Exception, bool> property to the RetryPolicy class to handle exception filtering. That can be done either in this PR or we can close this one and open a separate one.

[tomseida]

@cgillum, below is my understanding of your suggestion. This looks exactly like how retries worked for in-process. I am in full support of this since it simplifies function app upgrades from in-process to isolated. Please confirm that the below modification to RetryPolicy meets expectations. I am going to assume it does and alter this PR to make this work.

    /// <summary>
    /// Gets or sets a delegate to call on exception to determine if retries should proceed.
    /// </summary>
    public Func<Exception, bool>? Handle { get; set; }

#pragma warning disable SA1623 // Property summary documentation should match accessors
    /// <summary>
    /// This functionality is not implemented. Will be removed in the future. Use RetryPolicy.Handle or TaskOptions.FromRetryHandler instead.
    /// </summary>
    [Obsolete("This functionality is not implemented. Will be removed in the future. Use RetryPolicy.Handle or TaskOptions.FromRetryHandler instead.")]
    public Func<Exception, Task<bool>>? HandleAsync { get; set; }
#pragma warning restore SA1623 // Property summary documentation should match accessors

[tomseida]

Closing this pull request and replaced with PR #314 .