Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue problematic view dispatch call #1196

Closed
wants to merge 2 commits into from
Closed

Queue problematic view dispatch call #1196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b9427
Queue problematic view dispatch call
microbit-robert Nov 25, 2024
9127e5c
Wrap entire try block in queueMicrotask
microbit-robert Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/editor/codemirror/language-server/signatureHelp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,24 +91,26 @@ const triggerSignatureHelpRequest = async (
try {
// Must happen before other event handling that might dispatch more
// changes that invalidate our position.
queueMicrotask(() => {
queueMicrotask(async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the whole thing in queueMicrotask and use one view dispatch for all effects?

const result = await client.connection.sendRequest(
SignatureHelpRequest.type,
params
);
view.dispatch({
effects: [setSignatureHelpRequestPosition.of(pos)],
effects: [
setSignatureHelpRequestPosition.of(pos),
setSignatureHelpResult.of(result),
],
});
});
const result = await client.connection.sendRequest(
SignatureHelpRequest.type,
params
);
view.dispatch({
effects: [setSignatureHelpResult.of(result)],
});
} catch (e) {
if (!isErrorDueToDispose(e)) {
logException(state, e, "signature-help");
}
view.dispatch({
effects: [setSignatureHelpResult.of(null)],
queueMicrotask(() => {
view.dispatch({
effects: [setSignatureHelpResult.of(null)],
});
});
}
};
Expand Down