Queue problematic view dispatch call #1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
microbit-robert
commented
Nov 28, 2024
| @@ -91,24 +91,26 @@ const triggerSignatureHelpRequest = async ( | |||
| try { | |||
| // Must happen before other event handling that might dispatch more | |||
| // changes that invalidate our position. | |||
| queueMicrotask(() => { | |||
| queueMicrotask(async () => { | |||
There was a problem hiding this comment.
Put the whole thing in queueMicrotask and use one view dispatch for all effects?
|
@microbit-robert alternative approach on #1198. Still uses the same fix for this case but I think it removes the need to do anything unusual in other scenarios. |
|
Closed as we went with #1198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.