Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

190 implement stub JawsRunner #371

Merged
merged 18 commits into from
Mar 7, 2025
Merged

190 implement stub JawsRunner #371

merged 18 commits into from
Mar 7, 2025

Conversation

mbthornton-lbl
Copy link
Contributor

@mbthornton-lbl mbthornton-lbl commented Feb 5, 2025 •
edited
Loading

This PR provides:

  • JawsRunner stub class extending JobRunnerABC
  • jaws-client added to project dependencies
  • Python version and package version updates to support jaws-client
  • Python version update in CI build
  • basic integration test for jaws-client api
  • basic unit test for jaws-client api
  • configurations for both integration and unit tests

@mbthornton-lbl mbthornton-lbl linked an issue Feb 5, 2025 that may be closed by this pull request
Configure jaws-client and implement stub JawsRunner #190
Closed
@mbthornton-lbl mbthornton-lbl changed the title 190 implement jaws jobrunner 190 implement stub JawsRunner Feb 25, 2025
@mbthornton-lbl mbthornton-lbl marked this pull request as ready for review February 25, 2025 23:43
aclum
aclum reviewed Mar 7, 2025
View reviewed changes
aclum
aclum reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@aclum aclum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from including the token.

@mbthornton-lbl mbthornton-lbl requested a review from aclum March 7, 2025 20:30
@mbthornton-lbl mbthornton-lbl merged commit 4a2aff5 into main Mar 7, 2025
1 check passed
@mbthornton-lbl mbthornton-lbl deleted the 190-implement-jaws-jobrunner branch March 7, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclum aclum aclum approved these changes

@shreddd shreddd Awaiting requested review from shreddd

@mflynn-lanl mflynn-lanl Awaiting requested review from mflynn-lanl

@kaijli kaijli Awaiting requested review from kaijli

@AmitBinf AmitBinf Awaiting requested review from AmitBinf

@vlilanl vlilanl Awaiting requested review from vlilanl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure jaws-client and implement stub JawsRunner
2 participants
@mbthornton-lbl @aclum