Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error in donation eligibility calculation #2983

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: error in donation eligibility calculation #2983

merged 2 commits into from
Sep 24, 2024

Conversation

anshg1214
Copy link
Member

@anshg1214 anshg1214 commented Sep 18, 2024 •
edited
Loading

This PR fixes an issue where

  1. the calculation for determining donation eligibility could result in a division by zero when the payment_date is too recent (i.e., 0 days between now() and the payment_date).
  2. the donations are set as anonymous

@anshg1214 anshg1214 mentioned this pull request Sep 18, 2024
Merged
amCap1712
amCap1712 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@amCap1712 amCap1712 merged commit dc39ec5 into master Sep 24, 2024
2 checks passed
@amCap1712 amCap1712 deleted the ansh/fix-donation-api branch September 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amCap1712 amCap1712 amCap1712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshg1214 @amCap1712