-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Donation Leaderboard Page #2981
base: master
Are you sure you want to change the base?
Conversation
anshg1214
commented
Sep 16, 2024
•
edited
Loading
edited
Hello @anshg1214! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-09-18 03:44:40 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clean!
I love how we can fairly easily set up new pages without having to worry about data loading too much, with all the tools you put in place with the SPA refactor!
Would like some eyes form @Aerozol and @mayhem .
I just redeployed this PR to https://test.listenbrainz.org/donors/
I wonder if it would make sense to have a bit of a paragraph explaining that this is a list of MetaBrainz donors, not specifically ListenBrainz donors. Opinions welcome.
Looks great! So cool to see top donors!
Let me know if there's anything I can help with. |
@@ -98,13 +98,22 @@ function Donors() { | |||
{donor.musicbrainz_id && | |||
(donor.is_listenbrainz_user ? ( | |||
<Link | |||
to={`/user/${donor.musicbrainz_id}`} | |||
to={`${ | |||
!donor.is_listenbrainz_user && "https://musicbrainz.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this condition is never truthy,aas you are already inside a conditional check of donor.is_listenbrainz_user ? (...