-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display and preserve annotation of imported entities #1107
Display and preserve annotation of imported entities #1107
Conversation
TODO: The annotation still gets lost when the form is submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, perfect 🚀
Loading of an edition group import into the entity editor and `/imports/edition-group` routes were not working or being used.
This requires a BBID which imports do not have (yet): > error: select distinct "bookbrainz"."edition".* from "bookbrainz"."edition" where "master" = $1 and "bookbrainz"."edition"."edition_group_bbid" in ($2) - invalid input syntax for type uuid: "190"
You may have to drop existing views manually because of a PG limitation.
I've found a couple more issues while I was testing edition group imports (entity type name casing strikes again). One of them is even directly related to annotations, so I thought I might add these commits to this PR as well. |
'editionGroupType', | ||
'editions.defaultAlias', | ||
'editions.disambiguation', | ||
'editions.releaseEventSet.releaseEvents' | ||
// TODO: Reenable edition rels once imports have BBIDs | ||
// 'editions.defaultAlias', | ||
// 'editions.disambiguation', | ||
// 'editions.releaseEventSet.releaseEvents' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected trailing comma (comma-dangle)
Sigh, one more example why this ESLint rule is stupid... it often forces you to pointlessly edit neighbouring lines. Can we just disable this rule or migrate to always using dangling commas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have my blessing to disable the rule. I've never seen it as a relevant code styling rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I've dropped the rule in 2fc11a2. We might want to do the same across all repos, but I better won't do that now or I will find some more rules which should be changed or turned off 🤐
The rule to disallow trailing commas often forces you to pointlessly touch neighboring lines when you add or remove items. If we want to enforce consistent dangling commas, we should rather force them to always be present. But since our whole codebase follows this rule, it would be better to have a grace period to gradually add commas.
8bbf264
to
2fc11a2
Compare
Display annotations for all types of imported entities and preserve the annotation during the whole "Edit & Approve" process.
The corresponding changes for the "Approve" action are in metabrainz/bookbrainz-data-js#321.