Support series imports & Fix edition imports #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: The annotation still gets lost when the form is submitted.
Loading of an edition group import into the entity editor and `/imports/edition-group` routes were not working or being used.
This requires a BBID which imports do not have (yet): > error: select distinct "bookbrainz"."edition".* from "bookbrainz"."edition" where "master" = $1 and "bookbrainz"."edition"."edition_group_bbid" in ($2) - invalid input syntax for type uuid: "190"
You may have to drop existing views manually because of a PG limitation.
The rule to disallow trailing commas often forces you to pointlessly touch neighboring lines when you add or remove items. If we want to enforce consistent dangling commas, we should rather force them to always be present. But since our whole codebase follows this rule, it would be better to have a grace period to gradually add commas.
6 tasks
kellnerd
changed the title
MonkeyDo
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1107 (diff: kellnerd/bookbrainz-site@import-annotation...import-series)
Adds the missing routes, pages and data transformation functions for imported series.
Since imported entities can't have relationships yet, we have to handle the case that a series has no defined items (which wasn't necessary for regular series).
And I forgot to add the item entity type to the SQL view in one of my previous PRs.
Since the necessary changes to make editing and approval of edition imports work are very minor, I have included these here as well.