fix(commitlint): allow lowercase footer keyword values #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ole Petter <[email protected]>
Merged
kacf
reviewed
Apr 28, 2022
| @@ -324,7 +324,7 @@ function lint_required_footer_values() { | |||
| function verify_changelog(changelog) { | |||
| # Strip the CHANGELOG[(fix|feat)] prefix | |||
| gsub(CHANGELOG_PREFIX, "", changelog) | |||
| if ( match(changelog, "(None|Title|Commit|All|\\S+(\\s+\\S+){2,})") == 0 ) { | |||
| if ( match(changelog, "([Nn]one|[Tt]itle|[Cc]ommit|[Aa]ll|\\S+(\\s+\\S+){2,})") == 0 ) { | |||
There was a problem hiding this comment.
This is ok, but I was thinking that we can just use case insensitive matchers, like re.IGNORECASE in Python. Not sure what the awk equivalent is. In general I don't think case is significant in any of these fields.
I think this would still not allow changelog: title, for example? And same for ticket. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ole Petter [email protected]