Fix commitlint bug #186
Fix commitlint bug #186
Conversation
This simply adds the ability for the lexer to store the token type, as well as the value. Could prove handy, and really is standard procedure. Signed-off-by: Ole Petter <[email protected]>
Signed-off-by: Ole Petter <[email protected]>
Signed-off-by: Ole Petter <[email protected]>
There was a problem hiding this comment.
Btw, I saw in Slack that someone had a problem with letter casing also (Changelog: title instead of Changelog: Title). It would be nice if we could accept either of those. I'm just thinking of contributors, it saves an entire round trip if they make a mistake, and rejecting lowercase is kind of silly. Do you agree?
| advance() | ||
| } | ||
| # Require empty line afterwards in paragraph | ||
| empty_line("A 'Changelog' over multiple lines needs to have a trailing empty line") |
There was a problem hiding this comment.
This won't barf if the changelog paragraph is the last line, will it?
Edit: Actually, I guess it will never happen, because signoff always comes after.
Yeh, I agree. Let's fix 💪 |
No description provided.