Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark done #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mark done #91

wants to merge 2 commits into from

Conversation

sitano
Copy link

@sitano sitano commented Jul 19, 2024

Allow the user to select and delete/done notifications with ctrl-x.
I changed individual Done to ctrl-x and comment to ctrl-c. Not sure about what are good keys for that.
in continuation of #90.

Signed-off-by: Ivan Prisyazhnyy <[email protected]>
@LangLangBart
Copy link
Collaborator

rebased

@LangLangBart
Copy link
Collaborator

Comment to ctrl-c.

⌃ Control + C is typically used for canceling. Set it to ⌃ Control + O for now.

Done to ctrl-x

Okay.


The issue is that there is no done field, as mentioned in the referenced issue. Therefore, I won't merge it for now unless GitHub adds this feature or @meiji163 also desires this feature.

@sitano sitano mentioned this pull request Jul 23, 2024
@sitano
Copy link
Author

sitano commented Jul 23, 2024

@LangLangBart I see your point. Responded in #47 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants