Skip to content

Commit

Permalink
feat: add individual done
Browse files Browse the repository at this point in the history
Signed-off-by: Ivan Prisyazhnyy <[email protected]>
  • Loading branch information
sitano authored and LangLangBart committed Jul 21, 2024
1 parent 0f8e54a commit 361ea53
Showing 1 changed file with 21 additions and 1 deletion.
22 changes: 21 additions & 1 deletion gh-notify
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ GH_NOTIFY_PER_PAGE_LIMIT=50
: "${GH_NOTIFY_VIEW_PATCH_KEY:=ctrl-p}"
: "${GH_NOTIFY_RELOAD_KEY:=ctrl-r}"
: "${GH_NOTIFY_MARK_READ_KEY:=ctrl-t}"
: "${GH_NOTIFY_COMMENT_KEY:=ctrl-x}"
: "${GH_NOTIFY_MARK_DONE_KEY:=ctrl-x}"
: "${GH_NOTIFY_COMMENT_KEY:=ctrl-c}"
: "${GH_NOTIFY_TOGGLE_KEY:=ctrl-y}"
: "${GH_NOTIFY_RESIZE_PREVIEW_KEY:=btab}"
: "${GH_NOTIFY_VIEW_KEY:=enter}"
Expand Down Expand Up @@ -162,6 +163,7 @@ ${WHITE_BOLD}Key Bindings fzf${NC}
${GREEN}${GH_NOTIFY_VIEW_PATCH_KEY} ${NC} view diff in patch format
${GREEN}${GH_NOTIFY_RELOAD_KEY} ${NC} reload
${GREEN}${GH_NOTIFY_MARK_READ_KEY} ${NC} mark the selected notification as read and reload
${GREEN}${GH_NOTIFY_MARK_DONE_KEY} ${NC} mark the selected notification as done and reload
${GREEN}${GH_NOTIFY_COMMENT_KEY} ${NC} write a comment with the editor and quit
${GREEN}${GH_NOTIFY_TOGGLE_KEY} ${NC} toggle the selected notification
${GREEN}esc ${NC} quit
Expand Down Expand Up @@ -538,6 +540,22 @@ mark_individual_read() {
fi
}

mark_individual_done() {
local thread_id thread_state
# TODO: Investigate potential rate-limiting issues when sending too many requests in short
# succession. I didn't encounter any rate-limiting when testing with 100 unread notifications,
# but further testing is needed to be sure.

# Running commands in the background of a script can cause it to hang, especially if the
# command outputs to stdout: https://tldp.org/LDP/abs/html/x9644.html#WAITHANG
while IFS=' ' read -r _ thread_id thread_state _; do
if [[ $thread_state == "UNREAD" ]]; then
# https://docs.github.com/en/rest/activity/notifications#mark-a-thread-as-done
gh_rest_api --silent --method DELETE "notifications/threads/${thread_id}" &>/dev/null &
fi
done <"$1"
}

select_notif() {
local output expected_key selected_line repo_full_name type num
# Export functions to child processes. 'fzf' executes commands with $SHELL -c; to ensure
Expand All @@ -546,6 +564,7 @@ select_notif() {
export -f process_page process_discussion process_url gh_rest_api
export -f highlight_output open_in_browser view_notification view_in_pager
export -f mark_all_read mark_individual_read
export -f mark_individual_done
# The 'die' function is not exported because 'fzf' warns you about the error in
# a failed 'print_notifs' call, but does not display the message.

Expand All @@ -561,6 +580,7 @@ select_notif() {
--bind "${GH_NOTIFY_VIEW_PATCH_KEY}:toggle-preview+change-preview:if command grep -q PullRequest <<<{10}; then command gh pr diff {11} --patch --repo {5} | highlight_output; else view_notification {}; fi" \
--bind "${GH_NOTIFY_RELOAD_KEY}:reload:print_notifs || true" \
--bind "${GH_NOTIFY_MARK_READ_KEY}:execute-silent(mark_individual_read {+f})+reload:print_notifs || true" \
--bind "${GH_NOTIFY_MARK_DONE_KEY}:execute-silent(mark_individual_done {+f})+reload:print_notifs || true" \
--bind "${GH_NOTIFY_TOGGLE_KEY}:toggle+down" \
--bind "${GH_NOTIFY_VIEW_KEY}:execute:view_in_pager {}" \
--bind "${GH_NOTIFY_TOGGLE_PREVIEW_KEY}:toggle-preview+change-preview:view_notification {}" \
Expand Down

0 comments on commit 361ea53

Please sign in to comment.