-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load sounds with protobuf #1074
Conversation
reviews are welcome at every stage of this PR! |
versions that do not use protobuf this error is displayed maybe |
any more changes needed? |
Quality Gate passedIssues Measures |
Description
This is a continuation of bringing expanded protobuf support to otclient.
This isn't a complete solution but moves us very close to forwarding protobuf soundbanks to the client
These things are "to do", that won't be part of this PR:
Type of change
(note on "breaking" checkbox: current sound files will be moved to another place as data/sounds will work like data/things when I finish this PR)
How Has This Been Tested
(requires "enable audio" option checked)
terminal:
g_sounds.play('/sounds/1320/' .. g_sounds.getAudioFileNameById(4))
Checklist