Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken anchors for regular vertical scrollbar #1040

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

nekiro
Copy link
Collaborator

@nekiro nekiro commented Jan 14, 2025

Description

Fix some incorrectly aligned scrollbars in ui

Fixes

Fix #1036 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@nekiro nekiro changed the title Fix broken anchors for regular vertical scrollbar fix: broken anchors for regular vertical scrollbar Jan 14, 2025
@nekiro nekiro force-pushed the fix-broken-anchors branch from 5dd88f4 to 9195b42 Compare January 14, 2025 08:40
@Nottinghster Nottinghster merged commit fa76caa into mehah:main Jan 14, 2025
12 checks passed
@nekiro nekiro deleted the fix-broken-anchors branch January 14, 2025 13:14
@lucasoares
Copy link
Contributor

lucasoares commented Jan 16, 2025

I think the scrollbars is still not aligned correctly @Nottinghster @nekiro

How it is:
image

How it should be:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants