Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: horizontal scrollbars are not correctly aligned #1053

Merged
merged 4 commits into from
Jan 18, 2025

Conversation

lucasoares
Copy link
Contributor

@lucasoares lucasoares commented Jan 16, 2025

Description

Even after #1040 and #1036, the horizontal scrollbars are not correctly aligned.

I ask you all to help testing this before merging, because the last PR on scrolls I made, everything was working for me but still some scrollbars got mixed up. @nekiro please review the changes, since you made the last change.

Thanks.

Before:
image

After:
image

(#1040 (comment))

Also the marked scrollbar was not aligned too:

Before:
image

After:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@mehah mehah requested review from Nottinghster, nekiro, luanluciano93 and kokekanon and removed request for Nottinghster January 18, 2025 02:58
Copy link
Collaborator

@kokekanon kokekanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very detail-oriented(To spot that, i need a magnifying glass, xd), but it doesn't break anything

@mehah mehah merged commit cc098c9 into mehah:main Jan 18, 2025
12 checks passed
@lucasoares
Copy link
Contributor Author

I'm not very detail-oriented(To spot that, i need a magnifying glass, xd), but it doesn't break anything

hahahaha these little details makes me very sad, so I will fix them all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants