Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebExt: remove msedge compat data license and improve content #37449

Merged
merged 2 commits into from
Dec 30, 2024
Merged

WebExt: remove msedge compat data license and improve content #37449

merged 2 commits into from
Dec 30, 2024
+1 −12

Conversation

PassionPenguin
Copy link
Contributor

Description

  1. removed msedge compat data licesnes information (per fix(WebExtensions): remove note about MS Edge compat data license #22639)
  2. improve the description:
- A suggestion can be deleted when {{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}}`.deletable` is set to true.
+ A suggestion can be deleted when the property `deletable` of {{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}} is set to true.

@PassionPenguin PassionPenguin requested a review from a team as a code owner December 30, 2024 12:58
@PassionPenguin PassionPenguin requested review from dotproto and removed request for a team December 30, 2024 12:58
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed labels Dec 30, 2024
@PassionPenguin PassionPenguin mentioned this pull request Dec 30, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Preview URLs

Flaws (49)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Browser_support_for_JavaScript_APIs
Title: Browser support for JavaScript APIs
Flaw count: 49

  • macros:
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
    • and 44 more flaws omitted

(comment last updated: 2024-12-30 13:01:15)

@PassionPenguin PassionPenguin mentioned this pull request Dec 30, 2024
Merged
rebloor
rebloor approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PassionPenguin

@rebloor rebloor merged commit 873e383 into mdn:main Dec 30, 2024
8 checks passed
@PassionPenguin PassionPenguin deleted the fix branch December 31, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor rebloor approved these changes

@dotproto dotproto Awaiting requested review from dotproto dotproto is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PassionPenguin @rebloor