Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: create omnibox.onDeleteSuggestion #25087

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Conversation

PassionPenguin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Dec 15, 2024
Copy link
Contributor

github-actions bot commented Dec 15, 2024

Preview URLs

Flaws (13)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/omnibox/onDeleteSuggestion
Title: omnibox.onDeleteSuggestion
Flaw count: 13

  • macros:
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Background_scripts does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Working_with_files does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_files
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
    • and 8 more flaws omitted
External URLs (1)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/omnibox/onDeleteSuggestion
Title: omnibox.onDeleteSuggestion

(comment last updated: 2024-12-31 00:25:37)

@PassionPenguin PassionPenguin marked this pull request as ready for review December 15, 2024 14:44
@PassionPenguin PassionPenguin requested a review from a team as a code owner December 15, 2024 14:44
@PassionPenguin PassionPenguin requested review from irvin and removed request for a team December 15, 2024 14:44
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请参考 #25072 进行修改


{{AddonSidebar}}

当用户删除一个建议的时候触发。{{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}} 的 `.deletable` 为 `true` 的建议可以被删除。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

属性是不包含点的,这样写很奇怪,要么去掉点

Suggested change
当用户删除一个建议的时候触发。{{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}} 的 `.deletable``true` 的建议可以被删除。
当用户删除一个建议的时候触发。{{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}} 的 `deletable``true` 的建议可以被删除。

要么去掉“的”:

Suggested change
当用户删除一个建议的时候触发。{{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}}`.deletable``true` 的建议可以被删除。
当用户删除一个建议的时候触发。{{WebExtAPIRef("omnibox.SuggestResult","SuggestResult")}}`.deletable``true` 的建议可以被删除。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我也一并在上游提了,等等看看吧 :)

(下次该去 yin1999/translated-content 的分支提 PR,这次脑抽了,实在抱歉……)

Comment on lines 56 to 57
>
> Microsoft Edge 兼容性数据由微软集团提供,并在知识共享署名 3.0 美国协议下包含于本文中。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

兼容性数据的说明应该得删掉,等待上游 PR 合并:mdn/content#37448

Suggested change
>
> Microsoft Edge 兼容性数据由微软集团提供,并在知识共享署名 3.0 美国协议下包含于本文中。

@PassionPenguin
Copy link
Contributor Author

awaiting upstream content changes (per mdn/content#37449)

@yin1999 yin1999 merged commit 6f14d8b into mdn:main Dec 31, 2024
7 checks passed
@PassionPenguin PassionPenguin deleted the omnibox-1 branch December 31, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants