Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dynamic button label for screenreader users #37355

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fixes dynamic button label for screenreader users #37355

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e2dc14
Replaces dynamic label by static as
himanshugarg Dec 24, 2024
900247e
Merge branch 'main' into fix/dynamic_button_label
himanshugarg Dec 24, 2024
0feded8
Merge branch 'main' into fix/dynamic_button_label
himanshugarg Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions files/en-us/web/accessibility/aria/attributes/aria-expanded/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ Use the `aria-owns` property on the elements that own expandable grouping contai

### Buttons

A button that opens a widget should have `aria-controls` set to the [`id`](/en-US/docs/Web/HTML/Global_attributes/id) of the expandable widget and `aria-expanded` set to the current state of the widget.
A button that toggles a widget should have `aria-controls` set to the [`id`](/en-US/docs/Web/HTML/Global_attributes/id) of the toggled widget and `aria-expanded` set to the current state of the widget.

```html
<button aria-expanded="false" aria-controls="widget1">Show widget</button>
<button aria-expanded="false" aria-controls="widget1">Toggle widget</button>
```

When the widget is visible, the controlling object relays that information via having `aria-expanded="true"` set on it. The accessible name of the controlling object should reflect this change.

```html
<button aria-expanded="true" aria-controls="widget1">Hide widget</button>
<button aria-expanded="true" aria-controls="widget1">Toggle widget</button>
```

### Menu
Expand Down
Loading