Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes dynamic button label for screenreader users #37355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes dynamic button label for screenreader users #37355

wants to merge 2 commits into from
+3 −3

Conversation

himanshugarg
Copy link
Contributor

@himanshugarg himanshugarg commented Dec 24, 2024 •
edited
Loading

Description

The label of the button changes on click which doesn't sync with the aria-expanded attribute

Motivation

Low hanging 🍓

Additional details

Thanks @goetsu for reporting

Related issues and pull requests

Fixes #36900

@himanshugarg himanshugarg requested review from a team as code owners December 24, 2024 03:55
@himanshugarg himanshugarg requested review from scottaohara and hamishwillee and removed request for a team December 24, 2024 03:55
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:SVG SVG docs size/s [PR only] 6-50 LoC changed labels Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 24, 2024 •
edited
Loading

Preview URLs

Flaws (8)

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded
Title: aria-expanded
Flaw count: 8

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Accessibility/
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Accessibility/What_is_accessibility
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Accessibility/HTML
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Accessibility/CSS_and_JavaScript
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Accessibility/WAI-ARIA_basics
    • and 3 more flaws omitted

(comment last updated: 2024-12-24 04:07:29)

@himanshugarg
Replaces dynamic label by static as
2e2dc14 
aria-expanded attribute sufficiently captures this
@himanshugarg himanshugarg force-pushed the fix/dynamic_button_label branch from f0e05cf to 2e2dc14 Compare December 24, 2024 03:59
@github-actions github-actions bot removed the Content:SVG SVG docs label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee was automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

confusing label for button example
2 participants
@himanshugarg @scottaohara