Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF129 SubtleCrypto - support for Ed25519 #34989
FF129 SubtleCrypto - support for Ed25519 #34989
Changes from 5 commits
b85cd5d
18e3861
bb16d24
dcd0105
1ab1438
16f10d2
cc9e3da
27fa5b4
7c6911e
102fa60
75a4027
8f96284
db3ae2c
7e44156
7ce4301
e411874
f596ae6
e3f2774
0c6d31d
38e21a8
7b7f25c
3eba474
d152975
612e1be
ce31bd2
de52774
0275474
9a03b1d
f12a884
22daadc
aeccba8
1e3139a
b6f9f9a
947664f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is picky, and very optional, but I don't much like live samples that run when the page runs, then you can never run again. To me it breaks the link between the code and the result, it might as well just be a canned response. So I'd always rather give the user a button to push (and a "reset" button) so they can see the code running when they are ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is like a canned response, and I'm OK with that because at least it is a "live" response that shows things are working.
That said, I have added a run button that you can use here, and if you click it again it will run again - though since it will produce the same result that won't be interesting.