FF129 SubtleCrypto - support for Ed25519 #34989

hamishwillee · 2024-07-23T07:05:52Z

FF129 adds support for the Ed25519 signing algorithm in https://bugzilla.mozilla.org/show_bug.cgi?id=1804788. There is a bit a background on these here: https://github.com/tQsW/webcrypto-curve25519/blob/master/explainer.md#support-curve25519-in-the-web-cryptography-api

This adds docs where appropriate - i.e. where the two algorithms are used. There is a generate keys/sign/verify live example for Ed25519 created in SubtleCrypto.sign() that I also link from verify().

There is also support for the key agreement algorithm X25519 in chrome behind a flag, and likely to come in FF nightly next month. I did not do examples for X25519 yet, but plan for that when it appears in FF nightly.
I did however mention the algorithm in the syntax where it can be used.

I also tidied the top level Web API overview. More work could be done here and in SubtleCrypto to make more consistent, but not in this update.

Fixes #30886

Related docs work can be tracked in #34708

github-actions · 2024-07-23T07:07:28Z

Preview URLs (10 pages)

External URLs (12)

URL: /en-US/docs/Web/API/SubtleCrypto/generateKey
Title: SubtleCrypto: generateKey() method

https://mdn.github.io/dom-examples/web-crypto/sign-verify/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/SubtleCrypto/deriveKey
Title: SubtleCrypto: deriveKey() method

https://datatracker.ietf.org/doc/html/rfc6090 (1 time) (Note! This may be a new URL 👀)
https://en.wikipedia.org/wiki/Curve25519 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/SubtleCrypto/sign
Title: SubtleCrypto: sign() method

https://csrc.nist.gov/csrc/media/publications/fips/198/1/final/documents/fips-198-1_final.pdf (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc4754 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc6090 (1 time) (Note! This may be a new URL 👀)
https://en.wikipedia.org/wiki/Curve25519 (1 time) (Note! This may be a new URL 👀)
https://mdn.github.io/dom-examples/web-crypto/sign-verify/ (1 time) (Note! This may be a new URL 👀)
https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf (2 times) (Note! This may be a new URL 👀)
https://standards.ieee.org/ieee/1363/2049/ (1 time) (Note! This may be a new URL 👀)
https://www.itu.int/rec/T-REC-X.509 (1 time) (Note! This may be a new URL 👀)
https://www.openssl.org (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-08-06 01:32:06)

github-actions · 2024-07-25T14:27:38Z

This pull request has merge conflicts that must be resolved before it can be merged.

files/en-us/web/api/subtlecrypto/index.md

files/en-us/web/api/web_crypto_api/index.md

files/en-us/web/api/subtlecrypto/sign/index.md

- update table of supported algos - Tidy up the algorithms to be a bit more monolithic and cross link

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

files/en-us/web/api/subtlecrypto/generatekey/index.md

files/en-us/web/api/subtlecrypto/importkey/index.md

github-actions · 2024-08-04T23:21:28Z

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions · 2024-08-04T23:21:28Z

This pull request has merge conflicts that must be resolved before it can be merged.

files/en-us/web/api/subtlecrypto/generatekey/index.md

Co-authored-by: wbamberg <[email protected]>

hamishwillee · 2024-08-05T04:22:45Z

@wbamberg Thanks for your additional review. All accepted and or/integrated. I left the ones you might want to discuss unresolved. But I very much hope this is good.

On the plus side, the X25519 is in FF130 which I have assigned myself. But the changes for that should just be a small example now plus anything that we leave hanging out of this.

wbamberg

Thanks for the update! I just had a bit more picking over of "supported algorithms" for sign().

files/en-us/web/api/subtlecrypto/sign/index.md

Co-authored-by: wbamberg <[email protected]>

files/en-us/web/api/subtlecrypto/sign/index.md

hamishwillee · 2024-08-06T01:32:41Z

Reading the spec and finding out new things. Where will it lead. All changes accepted.

wbamberg

👍 thank you for your continued patience, Hamish!

hamishwillee · 2024-08-06T03:03:17Z

👍 thank you for you continued patience, Hamish!

@wbamberg I was going to say the same thing. Your feedback makes me feel "a bit too" sloppy.

Josh-Cena · 2024-08-06T15:52:18Z

files/en-us/web/api/subtlecrypto/sign/index.md


 ### HMAC

-The HMAC algorithm calculates and verifies hash-based message authentication codes according to the
-[FIPS 198-1 standard](https://csrc.nist.gov/files/pubs/fips/198-1/final/docs/fips-198-1_final.pdf).
+The HMAC algorithm calculates and verifies hash-based message authentication codes according to the [FIPS 198-1 standard](https://csrc.nist.gov/csrc/media/publications/fips/198/1/final/documents/fips-198-1_final.pdf).


@hamishwillee This PDF link gets redirected so I replaced it in #35222, but it got reverted in this PR. Was it for any particular reason?

No. I've been working in this issue for weeks and didn't see a conflict or I would have taken your change.

Ah I see. I assumed so too.

@Josh-Cena Cool. Did you re-revert it, or is that a job on me?

I already fixed this in another redirected link fix PR ^^

github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jul 23, 2024

hamishwillee mentioned this pull request Jul 23, 2024

SubtleCrypto: sign() method missing Ed25519 in Supported algorithms #30886

Closed

hamishwillee mentioned this pull request Jul 23, 2024

[WebAPI] Support for WebCrypto Curve25519: Ed25519 #34708

Closed

10 tasks

hamishwillee changed the title ~~FF129 SubtlCrypto - support for Ed25519~~ FF129 SubtleCrypto - support for Ed25519 Jul 23, 2024

github-actions bot added the merge conflicts 🚧 [PR only] label Jul 25, 2024

hamishwillee commented Jul 26, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/index.md Outdated Show resolved Hide resolved

github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jul 26, 2024

hamishwillee force-pushed the ff129subtlcrypto_Ed25519 branch from 8fdf19e to 4b7db98 Compare July 29, 2024 03:24

github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 29, 2024

hamishwillee force-pushed the ff129subtlcrypto_Ed25519 branch from 4b7db98 to 85ffee7 Compare July 29, 2024 03:38

hamishwillee commented Jul 29, 2024

View reviewed changes

files/en-us/web/api/web_crypto_api/index.md Show resolved Hide resolved

hamishwillee commented Jul 29, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/sign/index.md Show resolved Hide resolved

hamishwillee marked this pull request as ready for review July 29, 2024 05:42

hamishwillee requested a review from a team as a code owner July 29, 2024 05:42

hamishwillee requested review from wbamberg and removed request for a team July 29, 2024 05:42

hamishwillee and others added 5 commits July 30, 2024 10:13

FF129 SubtlCrypto - support for Ed25519

b85cd5d

- update table of supported algos - Tidy up the algorithms to be a bit more monolithic and cross link

Web Crypto API overview - list interfaces

18e3861

Add params for ED25519 and X25519 on the methods that use it

bb16d24

Update files/en-us/web/api/subtlecrypto/sign/index.md

dcd0105

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Prettier sign()

1ab1438

hamishwillee force-pushed the ff129subtlcrypto_Ed25519 branch from e265340 to 1ab1438 Compare July 30, 2024 00:13

dipikabh requested a review from bsmth July 30, 2024 23:04

bsmth reviewed Jul 31, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/generatekey/index.md Outdated Show resolved Hide resolved

bsmth reviewed Jul 31, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/generatekey/index.md Outdated Show resolved Hide resolved

bsmth reviewed Jul 31, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/importkey/index.md Outdated Show resolved Hide resolved

hamishwillee added 2 commits August 5, 2024 11:39

deriveKey - separate algos by key-derivation/agreement heading

ce31bd2

No one expects the spanish inquisition

de52774

hamishwillee commented Aug 5, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/generatekey/index.md Outdated Show resolved Hide resolved

hamishwillee and others added 2 commits August 5, 2024 12:04

Apply suggestions from code review

0275474

Co-authored-by: wbamberg <[email protected]>

sign() - add back preamble for algos

9a03b1d

hamishwillee force-pushed the ff129subtlcrypto_Ed25519 branch from 11d4059 to 9a03b1d Compare August 5, 2024 02:23

hamishwillee added 3 commits August 5, 2024 13:57

Fix example scrolling + add run button to generate()

f12a884

Truncate encoded data

22daadc

Merge branch 'main' into ff129subtlcrypto_Ed25519

aeccba8

github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 5, 2024

hamishwillee requested a review from wbamberg August 5, 2024 04:17

wbamberg requested changes Aug 5, 2024

View reviewed changes

Update files/en-us/web/api/subtlecrypto/sign/index.md

1e3139a

Co-authored-by: wbamberg <[email protected]>

hamishwillee commented Aug 6, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/sign/index.md Outdated Show resolved Hide resolved

hamishwillee commented Aug 6, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/sign/index.md Outdated Show resolved Hide resolved

hamishwillee commented Aug 6, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/sign/index.md Outdated Show resolved Hide resolved

Apply suggestions from code review

b6f9f9a

hamishwillee commented Aug 6, 2024

View reviewed changes

files/en-us/web/api/subtlecrypto/sign/index.md Outdated Show resolved Hide resolved

Apply suggestions from code review

947664f

hamishwillee requested a review from wbamberg August 6, 2024 01:32

wbamberg approved these changes Aug 6, 2024

View reviewed changes

wbamberg merged commit 223d903 into mdn:main Aug 6, 2024
8 checks passed

hamishwillee deleted the ff129subtlcrypto_Ed25519 branch August 6, 2024 03:03

Josh-Cena reviewed Aug 6, 2024

View reviewed changes

Josh-Cena mentioned this pull request Nov 9, 2024

PBKDF2 is dropped from deriveKey algorithm parameter #36708

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FF129 SubtleCrypto - support for Ed25519 #34989

FF129 SubtleCrypto - support for Ed25519 #34989

hamishwillee commented Jul 23, 2024 •

edited

Loading

github-actions bot commented Jul 23, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024

github-actions bot commented Aug 4, 2024

github-actions bot commented Aug 4, 2024

hamishwillee commented Aug 5, 2024

wbamberg left a comment

hamishwillee commented Aug 6, 2024

wbamberg left a comment •

edited

Loading

hamishwillee commented Aug 6, 2024

Josh-Cena Aug 6, 2024

hamishwillee Aug 6, 2024

Josh-Cena Aug 6, 2024

hamishwillee Aug 9, 2024

Josh-Cena Aug 9, 2024

FF129 SubtleCrypto - support for Ed25519 #34989

FF129 SubtleCrypto - support for Ed25519 #34989

Conversation

hamishwillee commented Jul 23, 2024 • edited Loading

github-actions bot commented Jul 23, 2024 • edited Loading

github-actions bot commented Jul 25, 2024

github-actions bot commented Aug 4, 2024

github-actions bot commented Aug 4, 2024

hamishwillee commented Aug 5, 2024

wbamberg left a comment

Choose a reason for hiding this comment

hamishwillee commented Aug 6, 2024

wbamberg left a comment • edited Loading

Choose a reason for hiding this comment

hamishwillee commented Aug 6, 2024

Josh-Cena Aug 6, 2024

Choose a reason for hiding this comment

hamishwillee Aug 6, 2024

Choose a reason for hiding this comment

Josh-Cena Aug 6, 2024

Choose a reason for hiding this comment

hamishwillee Aug 9, 2024

Choose a reason for hiding this comment

Josh-Cena Aug 9, 2024

Choose a reason for hiding this comment

hamishwillee commented Jul 23, 2024 •

edited

Loading

github-actions bot commented Jul 23, 2024 •

edited

Loading

wbamberg left a comment •

edited

Loading