Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page: @media scan feature #31894

Merged
merged 3 commits into from
Jan 25, 2024
Merged

New page: @media scan feature #31894

merged 3 commits into from
Jan 25, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 24, 2024

this creates a new page.
the scan feature has been around since CSS 2, and is in media queries 3, 4 and 5.

Note that no links to this page have been added to this PR. This PR is part of the much larger Media query module update project. Links to this scan page will be added in a separate PR. This page addition was made in a small PR in hopes of avoiding creating a huge PR. The links will be in the large PR to prevent merge conflicts.

BCD issue made: mdn/browser-compat-data#21990

Larger project: openwebdocs/project#192

@estelle estelle requested a review from a team as a code owner January 24, 2024 19:40
@estelle estelle requested review from chrisdavidmills and removed request for a team January 24, 2024 19:40
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed labels Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/@media/scan
Title: scan
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.at-rules.media.scan

(comment last updated: 2024-01-25 17:31:26)

@estelle estelle added size/m [PR only] 51-500 LoC changed and removed size/l [PR only] 501-1000 LoC changed labels Jan 24, 2024
@estelle estelle mentioned this pull request Jan 24, 2024
9 tasks
@estelle estelle closed this Jan 24, 2024
@estelle estelle reopened this Jan 24, 2024
@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jan 24, 2024
@estelle estelle mentioned this pull request Jan 25, 2024
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple a small bits, @estelle. Approving so as not to hold you up.

files/en-us/web/css/@media/scan/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@media/scan/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@media/scan/index.md Outdated Show resolved Hide resolved
@estelle estelle merged commit 0e21d5f into mdn:main Jan 25, 2024
8 checks passed
@estelle estelle deleted the scan branch January 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants