-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media queries module #31903
Media queries module #31903
Conversation
Preview URLs (6 pages)
Flaws (5)Note! 5 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2024-01-26 20:44:22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle fabulous work as always. I've got a few suggestions for you, most of them minor.
One thing I did notice is that the Printing guide doesn't appear in the sidebar. Does that require a sidebar macro to be fiddled with?
files/en-us/web/css/css_media_queries/using_media_queries/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_media_queries/using_media_queries/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_media_queries/using_media_queries/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_media_queries/using_media_queries/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_media_queries/using_media_queries_for_accessibility/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_media_queries/using_media_queries_for_accessibility/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will change the order of the examples for "using" in the next commit.
Thanks @chrisdavidmills. I changed the examples and explanations for discrete, not, and not with parens. |
mdn/yari#10386 - adds the missing "Printing" to the CSSRef sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabulous work, @estelle. The not and discrete updates read so much better now. Couple more nitpicks, but approving so as not to hold you up.
files/en-us/web/css/css_media_queries/using_media_queries/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_media_queries/using_media_queries/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Mills <[email protected]>
CSS module landing page project
CSS media queries module and guides
scan is in a different PR: #31894 (merged)
media query glossary is in a different PR
#31754 (merged)
CSS conditional module is another PR (also merged)
Fixes openwebdocs/project#192