Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media queries module #31903

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Media queries module #31903

merged 11 commits into from
Jan 26, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 25, 2024

CSS module landing page project
CSS media queries module and guides

scan is in a different PR: #31894 (merged)

media query glossary is in a different PR
#31754 (merged)

CSS conditional module is another PR (also merged)

Fixes openwebdocs/project#192

@estelle estelle requested a review from a team as a code owner January 25, 2024 05:54
@estelle estelle requested review from chrisdavidmills and removed request for a team January 25, 2024 05:54
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xl [PR only] >1000 LoC changed labels Jan 25, 2024
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Preview URLs (6 pages)
Flaws (5)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_media_queries
Title: CSS media queries
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/@media/environment-blending does not exist
    • /en-US/docs/Web/CSS/@media/horizontal-viewport-segments does not exist
    • /en-US/docs/Web/CSS/@media/nav-controls does not exist
    • /en-US/docs/Web/CSS/@media/vertical-viewport-segments does not exist
    • /en-US/docs/Web/CSS/@media/video-color-gamut does not exist
External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_media_queries/Using_media_queries_for_accessibility
Title: Using media queries for accessibility

(comment last updated: 2024-01-26 20:44:22)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle fabulous work as always. I've got a few suggestions for you, most of them minor.

One thing I did notice is that the Printing guide doesn't appear in the sidebar. Does that require a sidebar macro to be fiddled with?

Copy link
Member Author

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change the order of the examples for "using" in the next commit.

@estelle
Copy link
Member Author

estelle commented Jan 25, 2024

Thanks @chrisdavidmills. I changed the examples and explanations for discrete, not, and not with parens.

@estelle
Copy link
Member Author

estelle commented Jan 26, 2024

mdn/yari#10386 - adds the missing "Printing" to the CSSRef sidebar.
Also added the cssref into printing. it was missing there too.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous work, @estelle. The not and discrete updates read so much better now. Couple more nitpicks, but approving so as not to hold you up.

@estelle estelle merged commit f7daf15 into mdn:main Jan 26, 2024
8 checks passed
@estelle estelle deleted the media branch March 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media queries
2 participants