Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chrome beforeunload dialog control behavior #20942

Merged
merged 10 commits into from
Oct 13, 2023
Merged

Update Chrome beforeunload dialog control behavior #20942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
562f471
Update Chrome beforeunload dialog control behavior
chrisdavidmills Oct 10, 2023
bfd030d
Merge branch 'main' into beforeunload-dialog-control-chrome-update
queengooborg Oct 10, 2023
bf80bfa
Clarify empty string returnValue behavior change in Chromium
chrisdavidmills Oct 11, 2023
3c94326
Merge branch 'beforeunload-dialog-control-chrome-update' of github.co…
chrisdavidmills Oct 11, 2023
5d807e4
update deprecated status for consistency, add remove data
chrisdavidmills Oct 11, 2023
34db457
Make information about returnValue consistent
chrisdavidmills Oct 11, 2023
2803b31
activation works with any truthy value
chrisdavidmills Oct 12, 2023
3002de1
Update api/BeforeUnloadEvent.json
chrisdavidmills Oct 12, 2023
037ab76
Update api/BeforeUnloadEvent.json
chrisdavidmills Oct 12, 2023
6957dcc
Merge branch 'main' into beforeunload-dialog-control-chrome-update
chrisdavidmills Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions api/BeforeUnloadEvent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,17 @@
"__compat": {
"spec_url": "https://html.spec.whatwg.org/multipage/browsing-the-web.html#dom-beforeunloadevent-returnvalue",
"support": {
"chrome": {
"version_added": "30"
},
"chrome": [
{
"version_added": "119"
},
{
"version_added": "30",
"version_removed": "119",
"partial_implementation": true,
"notes": "Before Chrome 119, an empty string incorrectly activated the confirmation dialog."
}
],
"chrome_android": "mirror",
"deno": {
"version_added": false
Expand Down Expand Up @@ -76,7 +84,7 @@
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
"deprecated": true
}
}
},
Expand Down
37 changes: 24 additions & 13 deletions api/Window.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,18 +356,24 @@
},
"event_returnvalue_activation": {
"__compat": {
"description": "Activation using <code>event.returnValue = \"string\";</code>",
"description": "Activation using <code>event.returnValue = <any-truthy-value>;</code>",
"support": {
"chrome": {
"version_added": "30"
},
"chrome": [
{
"version_added": "119"
},
{
"version_added": "30",
"version_removed": "118",
"partial_implementation": true,
"notes": "Incorrectly activated the dialog with an empty string value."
}
],
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": {
"version_added": "12"
},
"edge": "mirror",
"firefox": {
"version_added": "6"
},
Expand Down Expand Up @@ -434,16 +440,21 @@
"description": "Activation using <code>event.preventDefault()</code>",
"support": {
"chrome": {
"version_added": false
"version_added": "119"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": {
"version_added": "12",
"version_removed": "79"
},
"edge": [
{
"version_added": "119"
},
{
"version_added": "12",
"version_removed": "79"
}
],
"firefox": {
"version_added": "6"
},
Expand Down Expand Up @@ -472,7 +483,7 @@
},
"return_string_activation": {
"__compat": {
"description": "Activation using <code>return \"string\";</code>",
"description": "Activation using <code>return <any-truthy-value>;</code>",
"support": {
"chrome": {
"version_added": "1"
Expand Down