Update Chrome beforeunload dialog control behavior #20942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
merge conflicts 🚧
…m:chrisdavidmills/browser-compat-data into beforeunload-dialog-control-chrome-update
queengooborg
requested changes
Oct 12, 2023
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
queengooborg
added a commit
that referenced
this pull request
Oct 13, 2023
This reverts commit b3354d0.
|
This was not ready to be merged and the descriptions don't have the proper HTML escapes, so it will cause rendering issues. |
queengooborg
added a commit
that referenced
this pull request
Oct 13, 2023
|
@queengooborg dammnit, sorry about that. I was getting anxious because the corresponding content update got merged without the BCD being in place. Do you need me to submit this again? |
Elchi3
pushed a commit
to Elchi3/browser-compat-data
that referenced
this pull request
Nov 14, 2023
* Update Chrome beforeunload dialog control behavior * Clarify empty string returnValue behavior change in Chromium * update deprecated status for consistency, add remove data * Make information about returnValue consistent * activation works with any truthy value * Update api/BeforeUnloadEvent.json Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]> * Update api/BeforeUnloadEvent.json Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]> --------- Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Elchi3
pushed a commit
to Elchi3/browser-compat-data
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 119 includes an update to the
beforeunloadevent — it now triggers the "leave page?" confirmation dialog whene.preventDefault()is called upon the event firing, and doesn't do that whene.returnValueis set to an empty string. This PR updates the compat data appropriately.See https://chromestatus.com/feature/4968823574233088 for the implementation details; the engineer has informed me that the actual release version will be 119).
This is great because Chrome now behaves like other browsers, so this event is immediately more useful than it was.
I intend to update the corresponding docs too.
Test results and supporting details
Related issues