Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAR compiler compatibility break in image.h #2126

Closed
wants to merge 0 commits into from

Conversation

Karambite
Copy link
Contributor

@Karambite Karambite commented Nov 19, 2024

Updated image.h to avoid breaking for IAR compiler.

#ifndef __packed
#define __packed __attribute__((__packed__))
#endif

This is a compatibility break with the IAR compiler. __packed is already a keyword that eliminates padding between members. This is not a definition, meaning it will always fall under the #ifndef. Any additions that use __packed will be replaced by the definition given.

I created a macro that will pack the structures based on the compiler used.

@nordicjm
Copy link
Collaborator

Commit needs a sign off and message text adding to commit i.e. git commit --amend -s then add description

@nordicjm
Copy link
Collaborator

@Karambite would you be able to fix this today or on Monday? Would like to pull latest changes into Zephyr with a manifest update soon

@Karambite
Copy link
Contributor Author

@Karambite would you be able to fix this today or on Monday? Would like to pull latest changes into Zephyr with a manifest update soon

Sorry I haven't had time to get back to this. I will try to close this over the weekend

@Karambite
Copy link
Contributor Author

I tried to rebase and accidentally closed this PR. A new one is opened here #2149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAR compiler compatibility break in image.h
2 participants