Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAR compiler compatibility break in image.h #2099

Open
Karambite opened this issue Oct 15, 2024 · 3 comments
Open

IAR compiler compatibility break in image.h #2099

Karambite opened this issue Oct 15, 2024 · 3 comments

Comments

@Karambite
Copy link
Contributor

Karambite commented Oct 15, 2024

#ifndef __packed
#define __packed __attribute__((__packed__))
#endif

This is a compatibility break with IAR compiler. __packed is already a keyword that eliminates padding between members. This is not a definition, meaning it will always fall under the #ifndef. Any additions that uses __packed will be replaced by the definition given. Since this macro is targeted for GCC compiler, this should either be wrapped around a macro that checks if the compiler being used is GCC.

@nordicjm
Copy link
Collaborator

Please submit a PR with the fix

@Karambite
Copy link
Contributor Author

PR has been created

@nordicjm nordicjm linked a pull request Nov 19, 2024 that will close this issue
@Karambite
Copy link
Contributor Author

New PR is #2149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants