Move es6-weak-map to dependencies #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only dependencies are installed by default by clients and as this is required at runtime it needs to be installed. Closes mcmath#14
|
Hi, I have the same problem, thanks for creating the PR. Can you merge it, @mcmath? |
|
ping @mcmath |
|
hey @mcmath |
|
ping @mcmath |
|
Because this project looks abandoned, I created map-values-deep using the same test suite and using lodash in the implementation since in the future it would be part of the API. |
|
Ping @mcmath |
micalevisk
approved these changes
Jan 8, 2022
Cruikshanks
added a commit
to DEFRA/water-abstraction-import
that referenced
this pull request
Nov 29, 2022
So, with our bump of the helpers everything broke! After investigation this was because `scripts/licence-creator/index.js` was requiring [deep-map](https://github.com/mcmath/deep-map) to do some work (see new comment in code to find out what that is). The problem is **deep-map** was then requiring `es6-weak-map` but only had it listed as a dev dependency. This is raised [as an issue](mcmath/deep-map#14) and someone has even gone to the effort of creating a [fix PR](mcmath/deep-map#15). But to no avail as these were done in 2019 and multiple pings to the contributor have not resulted in the fix being merged. The last release was 4 years ago so this is clearly an abandoned project. Also, we've been able to replicate what it was doing with very little extra code so it was unnecessary in the first place.
Cruikshanks
added a commit
to DEFRA/water-abstraction-import
that referenced
this pull request
Dec 1, 2022
DEFRA/water-abstraction-team#45 DEFRA/water-abstraction-helpers#200 This resolves an issue in specific scenarios where the logger in helpers expects an instance of `Error`. It also removes the dead deep-map dependency. When we bumped the helpers everything broke! After investigation, this was because `scripts/licence-creator/index.js` was requiring [deep-map](https://github.com/mcmath/deep-map) to do some work (see new comment in code to find out what that is). The problem is **deep-map** was then requiring `es6-weak-map` but only had it listed as a dev dependency. This is raised [as an issue](mcmath/deep-map#14) and someone has even gone to the effort of creating a [fix PR](mcmath/deep-map#15). But to no avail, as these were done in 2019 and multiple pings to the contributor have not resulted in the fix being merged. The last release was 4 years ago so this is clearly an abandoned project. Also, we've been able to replicate what it was doing with very little extra code so it was unnecessary in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only dependencies are installed by default by clients and as this
is required at runtime it needs to be installed.
Closes #14