Skip to content

Commit

Permalink
Update water-abstraction-helpers to latest version (#496)
Browse files Browse the repository at this point in the history
DEFRA/water-abstraction-team#45
DEFRA/water-abstraction-helpers#200

This resolves an issue in specific scenarios where the logger in helpers expects an instance of `Error`.

It also removes the dead deep-map dependency. When we bumped the helpers everything broke! After investigation, this was because `scripts/licence-creator/index.js` was requiring [deep-map](https://github.com/mcmath/deep-map) to do some work (see new comment in code to find out what that is).

The problem is **deep-map** was then requiring `es6-weak-map` but only had it listed as a dev dependency. This is raised [as an issue](mcmath/deep-map#14) and someone has even gone to the effort of creating a [fix PR](mcmath/deep-map#15). But to no avail, as these were done in 2019 and multiple pings to the contributor have not resulted in the fix being merged.

The last release was 4 years ago so this is clearly an abandoned project. Also, we've been able to replicate what it was doing with very little extra code so it was unnecessary in the first place.
  • Loading branch information
Cruikshanks authored Dec 1, 2022
1 parent 933a0b5 commit c1632dd
Show file tree
Hide file tree
Showing 3 changed files with 334 additions and 3,647 deletions.
Loading

0 comments on commit c1632dd

Please sign in to comment.